From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24985: Add missing provide statements Date: Fri, 25 Nov 2016 12:27:26 +0200 Message-ID: <83bmx34zxt.fsf@gnu.org> References: <8737ijlngz.fsf@gmx.de> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1480069694 20825 195.159.176.226 (25 Nov 2016 10:28:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 25 Nov 2016 10:28:14 +0000 (UTC) Cc: michael.albinus@gmx.de, 24985@debbugs.gnu.org To: Philippe Vaucher Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 25 11:28:07 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cADjh-0004D4-63 for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Nov 2016 11:28:05 +0100 Original-Received: from localhost ([::1]:45097 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cADjk-0006uw-TE for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Nov 2016 05:28:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44858) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cADjf-0006uq-94 for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 05:28:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cADje-0006OO-BV for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 05:28:03 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53945) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cADje-0006OI-8d for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 05:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cADje-0001Cf-3m for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 05:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Nov 2016 10:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24985-submit@debbugs.gnu.org id=B24985.14800696674604 (code B ref 24985); Fri, 25 Nov 2016 10:28:02 +0000 Original-Received: (at 24985) by debbugs.gnu.org; 25 Nov 2016 10:27:47 +0000 Original-Received: from localhost ([127.0.0.1]:41111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cADjP-0001CC-AF for submit@debbugs.gnu.org; Fri, 25 Nov 2016 05:27:47 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:53625) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cADjO-0001Bx-6T for 24985@debbugs.gnu.org; Fri, 25 Nov 2016 05:27:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cADjE-00068I-Lp for 24985@debbugs.gnu.org; Fri, 25 Nov 2016 05:27:40 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cADjE-00068E-J5; Fri, 25 Nov 2016 05:27:36 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2258 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1cADjD-00017Y-PB; Fri, 25 Nov 2016 05:27:36 -0500 In-reply-to: (message from Philippe Vaucher on Tue, 22 Nov 2016 14:58:19 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126078 Archived-At: > From: Philippe Vaucher > Date: Tue, 22 Nov 2016 14:58:19 +0100 > Cc: 24985@debbugs.gnu.org > > > (defalias 'toggle-auto-composition 'auto-composition-mode) > > > > +(provide 'auto-composition-mode) > > Why that? I would expect (provide 'composite) here. > > I thought that the most interesting thing in composite was auto-composition-mode... same reasoning for > replace.el which provided 'occur in my first patch. > > Anyway, you're right, it's not very consistent. Here attached is a new patch that simply follows the file name. Thanks, pushed to master. In the future, please start each sentence in the log entry with a capital letter, and end it with a period. Here's how I reformatted your log message: * lisp/composite.el: * lisp/replace.el: * lisp/textmodes/text-mode.el: Add provide statement.