From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24939: [PATCH] Add tests for lisp/kmacro.el Date: Wed, 30 Nov 2016 17:51:17 +0200 Message-ID: <83bmwxq83u.fsf@gnu.org> References: <834m3ahxic.fsf@gnu.org> <83vavphpac.fsf@gnu.org> <871sxtxrkx.fsf@gmx.de> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1480521162 4372 195.159.176.226 (30 Nov 2016 15:52:42 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 30 Nov 2016 15:52:42 +0000 (UTC) Cc: gazally@runbox.com, 24939@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 30 16:52:37 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cC7BU-0000Kk-2d for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Nov 2016 16:52:36 +0100 Original-Received: from localhost ([::1]:44778 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cC7BX-0007Hh-Uo for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Nov 2016 10:52:39 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46823) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cC7B0-0006zJ-Vf for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2016 10:52:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cC7Aw-0001mW-G7 for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2016 10:52:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60494) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cC7Aw-0001mH-Cy for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2016 10:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cC7Aw-0001Rw-7d for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2016 10:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Nov 2016 15:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24939 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24939-submit@debbugs.gnu.org id=B24939.14805210875526 (code B ref 24939); Wed, 30 Nov 2016 15:52:02 +0000 Original-Received: (at 24939) by debbugs.gnu.org; 30 Nov 2016 15:51:27 +0000 Original-Received: from localhost ([127.0.0.1]:47660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cC7AM-0001R3-Jh for submit@debbugs.gnu.org; Wed, 30 Nov 2016 10:51:26 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:55577) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cC7AL-0001Qq-47 for 24939@debbugs.gnu.org; Wed, 30 Nov 2016 10:51:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cC7AB-0001J9-B6 for 24939@debbugs.gnu.org; Wed, 30 Nov 2016 10:51:19 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56703) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cC7AB-0001J4-83; Wed, 30 Nov 2016 10:51:15 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2158 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cC7AA-0000UZ-7h; Wed, 30 Nov 2016 10:51:14 -0500 In-reply-to: <871sxtxrkx.fsf@gmx.de> (message from Michael Albinus on Wed, 30 Nov 2016 10:08:46 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126312 Archived-At: > From: Michael Albinus > Cc: Eli Zaretskii , 24939@debbugs.gnu.org > Date: Wed, 30 Nov 2016 10:08:46 +0100 > > > Eli Zaretskii writes: > > > >>> > I don't like this implementation. > >>> > >>> This strategy is used in autorevert-tests.el and filenotify-tests.el, > >>> which is where I copied it from. So those should be changed too. > >> > >> Most probably. But let's first see what better implementation we > >> could come up with. > >> > > Let me know what you think. > > At first glance, looks OK to me. I agree. Thanks for working on this, Gemini. > However, I didn't understand why the existing implementation > (watching messages in *Messages*) is bad. Because the display engine treats that buffer specially, and assumes all kinds of assumptions when it does. See message_dolog in xdisp.c for the gory details. So I'd like us to futz as little as possible with *Messages*, lest we violate those assumptions. In particular, setting buffer restrictions might get in the way. (Granted, this is only a problem when the test suite is run interactively, but AFAIK this is actually done sometimes.)