From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow Date: Mon, 12 Feb 2018 20:09:15 +0200 Message-ID: <83bmguyt9w.fsf@gnu.org> References: <87d28rt4jl.fsf@telefonica.net> <874lmxloo1.fsf@mail.linkov.net> <83fu692jdu.fsf@gnu.org> <87lgg0sgbz.fsf@mail.linkov.net> <83bmgv1ol3.fsf@gnu.org> <873727xxvf.fsf@linux-m68k.org> <8360731lr9.fsf@gnu.org> <87d11bwfly.fsf@linux-m68k.org> <83y3jzz7hr.fsf@gnu.org> <87vaf3cjbg.fsf@mail.linkov.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1518459227 19083 195.159.176.226 (12 Feb 2018 18:13:47 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 12 Feb 2018 18:13:47 +0000 (UTC) Cc: 19045@debbugs.gnu.org, schwab@linux-m68k.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 12 19:13:42 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1elIbl-0004aP-Pc for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Feb 2018 19:13:41 +0100 Original-Received: from localhost ([::1]:34652 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elIdn-0005Wb-H2 for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Feb 2018 13:15:47 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elIYK-0000ye-Ny for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2018 13:10:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elIYE-0004pS-N6 for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2018 13:10:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60326) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1elIYE-0004oj-It for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2018 13:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1elIYD-00056l-P4 for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2018 13:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Feb 2018 18:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19045 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19045-submit@debbugs.gnu.org id=B19045.151845897719598 (code B ref 19045); Mon, 12 Feb 2018 18:10:01 +0000 Original-Received: (at 19045) by debbugs.gnu.org; 12 Feb 2018 18:09:37 +0000 Original-Received: from localhost ([127.0.0.1]:39990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1elIXp-000562-62 for submit@debbugs.gnu.org; Mon, 12 Feb 2018 13:09:37 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:40660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1elIXn-00055p-Bc for 19045@debbugs.gnu.org; Mon, 12 Feb 2018 13:09:35 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elIXf-0003m1-18 for 19045@debbugs.gnu.org; Mon, 12 Feb 2018 13:09:30 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60238) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elIXe-0003lq-U1; Mon, 12 Feb 2018 13:09:26 -0500 Original-Received: from [176.228.60.248] (port=2870 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1elIXe-0004SW-8G; Mon, 12 Feb 2018 13:09:26 -0500 In-reply-to: <87vaf3cjbg.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 11 Feb 2018 23:22:59 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143212 Archived-At: > From: Juri Linkov > Cc: Andreas Schwab , 19045@debbugs.gnu.org > Date: Sun, 11 Feb 2018 23:22:59 +0200 > > > Juri, can you please re-check with directories? They seem to work > > fine here, so disabling them in this case sounds unnecessary. > > Please clarify where directories work fine: in git command line > or in Emacs using vc-git? The latter. > > In the command line of git version 1.9.1 running git log on two files > (command line copied from *Messages* when vc-command-messages is t) > > git --no-pager log --no-color --follow -n 2000 -- vc-dispatcher.el vc-git.el > > fails with the error: > > usage: git logs can only follow renames on one pathname at a time > > whereas running git on one directory ‘vc’ > > git --no-pager log --no-color --follow -n 2000 -- vc > > doesn't fail. Although I can't confirm the correctness of the output log: > it seems the option ‘--follow’ has no effect on directories. Even if it's true, it means --follow doesn't do any harm when invoked on directories, and we shouldn't disallow that. > Now there is a different story for vc-git.el. There are 4 versions of it: > > 1. the initial version without the option added in ‘vc-git-print-log’ > 2. the old version that always used "--follow" > 3. the previous version that added "--follow" only > when the arg ‘files’ contains no directories > 4. the current version that additionally checks the length of ‘files’ > and adds "--follow" only for a single file in ‘files’. > > Which version did you check? I tried #2.