From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#22000: Patch addressing the menu-bar frame-resize interaction Date: Thu, 18 Oct 2018 21:20:35 +0300 Message-ID: <83bm7rqfpo.fsf@gnu.org> References: <87k2p8h1vn.fsf@isaac.fritz.box> <5B52E425.8010608@gmx.at> <5B543148.1010004@gmx.at> <5B557ACA.4020106@gmx.at> <5BBF93CF.4060301@gmx.at> <5BC05EEB.9010609@gmx.at> <5BC0E405.90805@gmx.at> <5BC1AAE2.7070808@gmx.at> <5BC4DB0E.3050501@gmx.at> <5BC6E4F2.2030607@gmx.at> <5BC83F03.4050006@gmx.at> <83o9brqs6e.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1539886813 2878 195.159.176.226 (18 Oct 2018 18:20:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 18 Oct 2018 18:20:13 +0000 (UTC) Cc: 22000@debbugs.gnu.org, deng@randomsample.de To: Vivek Dasmohapatra Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 18 20:20:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDCu1-0000cM-3q for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Oct 2018 20:20:09 +0200 Original-Received: from localhost ([::1]:43748 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDCw6-0006rG-QL for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Oct 2018 14:22:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35248) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDCvw-0006pc-7i for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2018 14:22:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gDCvs-0006rA-C6 for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2018 14:22:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53100) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gDCvq-0006n2-0H for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2018 14:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gDCvp-0000p6-Rq for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2018 14:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Oct 2018 18:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22000 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22000-submit@debbugs.gnu.org id=B22000.15398868813116 (code B ref 22000); Thu, 18 Oct 2018 18:22:01 +0000 Original-Received: (at 22000) by debbugs.gnu.org; 18 Oct 2018 18:21:21 +0000 Original-Received: from localhost ([127.0.0.1]:57358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDCvB-0000oC-11 for submit@debbugs.gnu.org; Thu, 18 Oct 2018 14:21:21 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDCv8-0000nz-LI for 22000@debbugs.gnu.org; Thu, 18 Oct 2018 14:21:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gDCv0-0004mh-BI for 22000@debbugs.gnu.org; Thu, 18 Oct 2018 14:21:13 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38371) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDCup-0004Vq-UI; Thu, 18 Oct 2018 14:20:59 -0400 Original-Received: from [176.228.60.248] (port=3394 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gDCup-0006ve-Cg; Thu, 18 Oct 2018 14:20:59 -0400 In-reply-to: (message from Vivek Dasmohapatra on Thu, 18 Oct 2018 18:26:34 +0100 (BST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151393 Archived-At: > Date: Thu, 18 Oct 2018 18:26:34 +0100 (BST) > From: Vivek Dasmohapatra > cc: rudalics@gmx.at, 22000@debbugs.gnu.org, deng@randomsample.de > > >> + nil (or any other value) - the menu bar is truncated\n > >> +Note that prior to GTK 3.16 truncation is not possible and the default > >> +is equivalent to 'forced-resize.\n > > > > Do you really need these explicit \n newlines? > > I wouldn't say need but I find they make the documentation more readable, > per item 3 in (elisp)Top > Tips > Documentation tips … D.6 Tips for… Sure, but why not have them literally, so that reading the doc string in the code will also be easier. Like this: (defun menu-bar-scrollbar-mode (&optional mode) "Cycle through scroll/truncate/resize modes for GTK menu bars. If the optional parameter MODE is specified then apply that instead. The new mode is stored in the variable `menu-bar-scrollbar-mode' via the custom interface (but not automatically saved). Returns the new MODE. NOTE: pass 'default if you want to set the mode explicitly to nil. See `menu-bar-scrollbar' in Info node `(elisp)Layout Parameters' for details." > I will make the other changes suggested (to which I have not responded > individually here). Thanks.