From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33201: 26.1; Edebug doesn't work on closures with edebug-unwrap-results Date: Thu, 01 Nov 2018 22:18:40 +0200 Message-ID: <83bm78h7q7.fsf@gnu.org> References: <20181031150627.67149.qmail@mail.muc.de> <20181101100056.GA4504@ACM> <83sh0khdf6.fsf@gnu.org> <20181101195918.GD4504@ACM> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1541104326 12335 195.159.176.226 (1 Nov 2018 20:32:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 1 Nov 2018 20:32:06 +0000 (UTC) Cc: gazally@runbox.com, 33201@debbugs.gnu.org, darkfeline@felesatra.moe To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 01 21:32:01 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gIJdJ-00034i-Br for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Nov 2018 21:32:01 +0100 Original-Received: from localhost ([::1]:43887 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gIJfP-0001XH-Tx for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Nov 2018 16:34:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gIJf8-0000MC-F4 for bug-gnu-emacs@gnu.org; Thu, 01 Nov 2018 16:34:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gIJRj-0005tp-Uw for bug-gnu-emacs@gnu.org; Thu, 01 Nov 2018 16:20:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54582) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gIJRi-0005tG-Im for bug-gnu-emacs@gnu.org; Thu, 01 Nov 2018 16:20:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gIJRi-0002nv-3o for bug-gnu-emacs@gnu.org; Thu, 01 Nov 2018 16:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Nov 2018 20:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33201 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33201-submit@debbugs.gnu.org id=B33201.154110354910702 (code B ref 33201); Thu, 01 Nov 2018 20:20:02 +0000 Original-Received: (at 33201) by debbugs.gnu.org; 1 Nov 2018 20:19:09 +0000 Original-Received: from localhost ([127.0.0.1]:58840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gIJQn-0002mU-H6 for submit@debbugs.gnu.org; Thu, 01 Nov 2018 16:19:09 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gIJQl-0002ly-J7 for 33201@debbugs.gnu.org; Thu, 01 Nov 2018 16:19:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gIJQd-0004gA-7A for 33201@debbugs.gnu.org; Thu, 01 Nov 2018 16:18:58 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39444) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gIJQd-0004ec-2U; Thu, 01 Nov 2018 16:18:55 -0400 Original-Received: from [176.228.60.248] (port=3428 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gIJQc-0001oN-Ll; Thu, 01 Nov 2018 16:18:55 -0400 In-reply-to: <20181101195918.GD4504@ACM> (message from Alan Mackenzie on Thu, 1 Nov 2018 19:59:18 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151917 Archived-At: > Date: Thu, 1 Nov 2018 19:59:18 +0000 > Cc: darkfeline@felesatra.moe, gazally@runbox.com, 33201@debbugs.gnu.org > From: Alan Mackenzie > > It seems like in Emacs 26.1 edebug can't be reliably used with > edebug-unwrap-results non-nil because there's always a chance it will > encounter the symbol `closure', at which point it errors out. > [`closure' is wierd, because it has a meaning, yet has none of a > function, a value, a property list.] I understand, but why does this make it a "major" problem? The only major problem in Edebug I could understand is if Edebug could not be used at all in some popular situation. FWIW, I never set edebug-unwrap-results non-nil, and I'm a happy "Edebugger". > > I can: it's quite complex, and even includes gratuitous refactoring of > > 'cond' as 'pcase'. > > OK. How about me doing a simpler, but less lazy fix which would just > add handling of `closure' into the existing cond form? That's one thing; the other is why do we need to change edebug-unwrap1 as well? AFAIU, that takes care of a separate issue, right?