From: Eli Zaretskii <eliz@gnu.org>
To: monnier@IRO.UMontreal.CA
Cc: stephen_leake@member.fsf.org, 33618@debbugs.gnu.org
Subject: bug#33618: 27.0.50; ada-mode breaks M-x grep
Date: Wed, 05 Dec 2018 16:41:46 +0200 [thread overview]
Message-ID: <83bm60828l.fsf@gnu.org> (raw)
In-Reply-To: <83d0qg82fr.fsf@gnu.org> (message from Eli Zaretskii on Wed, 05 Dec 2018 16:37:28 +0200)
> Date: Wed, 05 Dec 2018 16:37:28 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: stephen_leake@member.fsf.org, 33618@debbugs.gnu.org
>
> > The patch I use changes compile.el so the var is looked up from the
> > buffer from which the compilation is launched (e.g. an ada-mode buffer)
> > and then stashed into the compilation buffer (for later use).
>
> What will that do if I invoke, e.g., "M-x recompile" from a source
> buffer other than the one from which I invoked the previous "M-x compile"?
> And what if we have multiple compilation buffers?
And, btw, isn't it wrong for a mode to set the value of a defcustom?
Maybe we should have a separate variable for this purpose, one that
isn't a defcustom. A buffer-local value of a defcustom is going to
surprise users, I think.
next prev parent reply other threads:[~2018-12-05 14:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 23:46 bug#33618: 27.0.50; ada-mode breaks M-x grep Stefan Monnier
2018-12-05 0:02 ` Stefan Monnier
2018-12-05 6:41 ` Eli Zaretskii
2018-12-05 14:26 ` Stefan Monnier
2018-12-05 14:37 ` Eli Zaretskii
2018-12-05 14:41 ` Eli Zaretskii [this message]
2018-12-05 16:10 ` Stefan Monnier
2018-12-20 20:17 ` bug#33618: emacs ada-mode bug 33618 Stephen Leake
2018-12-21 0:08 ` Dmitry Gutov
2018-12-21 23:19 ` bug#33618: update Stephen Leake
2019-01-04 17:27 ` bug#33618: 27.0.50; ada-mode breaks M-x grep Ludovic Brenta
2019-04-20 16:47 ` bug#33618: better fix Stephen Leake
2019-04-20 17:24 ` Eli Zaretskii
2019-04-25 22:52 ` bug#33618: fixed in commit 1486eadf7c9469f873fcd04beafd03f21564d580 Stephen Leake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bm60828l.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=33618@debbugs.gnu.org \
--cc=monnier@IRO.UMontreal.CA \
--cc=stephen_leake@member.fsf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).