From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34641: rx: (or ...) order unpredictable Date: Sun, 24 Feb 2019 21:06:34 +0200 Message-ID: <83bm31ngzp.fsf@gnu.org> References: <836B8DC2-9358-40AC-83AF-7C4D960D9A53@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="118696"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34641@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 24 20:07:23 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gxz7S-000Ul6-LJ for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Feb 2019 20:07:22 +0100 Original-Received: from localhost ([127.0.0.1]:54653 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxz7R-0003HG-JT for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Feb 2019 14:07:21 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41648) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxz7E-0003G9-Ge for bug-gnu-emacs@gnu.org; Sun, 24 Feb 2019 14:07:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gxz7D-00085g-QQ for bug-gnu-emacs@gnu.org; Sun, 24 Feb 2019 14:07:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36964) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gxz78-00082m-17 for bug-gnu-emacs@gnu.org; Sun, 24 Feb 2019 14:07:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gxz77-0007Oo-PB for bug-gnu-emacs@gnu.org; Sun, 24 Feb 2019 14:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Feb 2019 19:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34641 X-GNU-PR-Package: emacs Original-Received: via spool by 34641-submit@debbugs.gnu.org id=B34641.155103520828422 (code B ref 34641); Sun, 24 Feb 2019 19:07:01 +0000 Original-Received: (at 34641) by debbugs.gnu.org; 24 Feb 2019 19:06:48 +0000 Original-Received: from localhost ([127.0.0.1]:50508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxz6u-0007OM-5l for submit@debbugs.gnu.org; Sun, 24 Feb 2019 14:06:48 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxz6s-0007O6-DQ for 34641@debbugs.gnu.org; Sun, 24 Feb 2019 14:06:46 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45993) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxz6d-0007fK-OJ; Sun, 24 Feb 2019 14:06:34 -0500 Original-Received: from [176.228.60.248] (port=3304 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gxz6b-00034n-5U; Sun, 24 Feb 2019 14:06:30 -0500 In-reply-to: <836B8DC2-9358-40AC-83AF-7C4D960D9A53@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Sun, 24 Feb 2019 19:40:33 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155735 Archived-At: > From: Mattias Engdegård > Date: Sun, 24 Feb 2019 19:40:33 +0100 > > We could determine whether any string is a prefix of another. If not, regexp-opt should be safe to call. Alternatively, this check could be done in regexp-opt (activated by a flag). That would be my preferred short-term solution. Your preferred solution is fine with me, FWIW. > (Speaking of regexp-opt, it has another bug that does not affect rx: it returns the empty string if given an empty list of strings. The correct return value is a regexp that never matches anything. Fix it, document it, or turn it into an error?) Fix it, I think.