From: Eli Zaretskii <eliz@gnu.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 34641@debbugs.gnu.org
Subject: bug#34641: rx: (or ...) order unpredictable
Date: Sun, 24 Feb 2019 21:06:34 +0200 [thread overview]
Message-ID: <83bm31ngzp.fsf@gnu.org> (raw)
In-Reply-To: <836B8DC2-9358-40AC-83AF-7C4D960D9A53@acm.org> (message from Mattias Engdegård on Sun, 24 Feb 2019 19:40:33 +0100)
> From: Mattias Engdegård <mattiase@acm.org>
> Date: Sun, 24 Feb 2019 19:40:33 +0100
>
> We could determine whether any string is a prefix of another. If not, regexp-opt should be safe to call. Alternatively, this check could be done in regexp-opt (activated by a flag). That would be my preferred short-term solution.
Your preferred solution is fine with me, FWIW.
> (Speaking of regexp-opt, it has another bug that does not affect rx: it returns the empty string if given an empty list of strings. The correct return value is a regexp that never matches anything. Fix it, document it, or turn it into an error?)
Fix it, I think.
next prev parent reply other threads:[~2019-02-24 19:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-24 18:40 bug#34641: rx: (or ...) order unpredictable Mattias Engdegård
2019-02-24 19:06 ` Eli Zaretskii [this message]
2019-02-24 21:18 ` Mattias Engdegård
2019-02-24 22:44 ` Basil L. Contovounesios
2019-02-25 14:26 ` Mattias Engdegård
2019-03-02 12:33 ` Eli Zaretskii
2019-03-02 14:05 ` Mattias Engdegård
2019-03-02 14:08 ` Mattias Engdegård
2019-03-02 14:23 ` Eli Zaretskii
2019-03-02 14:37 ` Mattias Engdegård
2019-03-02 23:48 ` Phil Sainty
2019-03-03 8:54 ` Mattias Engdegård
2019-03-07 9:00 ` Phil Sainty
2019-02-25 2:37 ` Noam Postavsky
2019-02-25 9:56 ` Mattias Engdegård
2019-02-25 14:43 ` Noam Postavsky
2019-02-25 14:48 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bm31ngzp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=34641@debbugs.gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).