From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34781: 27.0.50; integer in pcase sometimes compared by eq Date: Fri, 29 Mar 2019 11:48:07 +0300 Message-ID: <83bm1ujcc8.fsf@gnu.org> References: <95f744d5-426d-1ce1-15fa-9c49aaf6f2f0@cs.ucla.edu> <3a02a3378a526c8706b33f36b85c003a82aa2aa1.camel@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="185548"; mail-complaints-to="usenet@blaine.gmane.org" Cc: eggert@cs.ucla.edu, monnier@iro.umontreal.ca, 34781@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 29 09:49:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h9nCO-000m6P-2K for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Mar 2019 09:49:16 +0100 Original-Received: from localhost ([127.0.0.1]:48789 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9nCN-0007M2-3a for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Mar 2019 04:49:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9nCB-0007Kn-VB for bug-gnu-emacs@gnu.org; Fri, 29 Mar 2019 04:49:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h9nCA-00065I-UK for bug-gnu-emacs@gnu.org; Fri, 29 Mar 2019 04:49:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49723) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h9nCA-000657-Mu for bug-gnu-emacs@gnu.org; Fri, 29 Mar 2019 04:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h9nCA-0005je-FW for bug-gnu-emacs@gnu.org; Fri, 29 Mar 2019 04:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Mar 2019 08:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34781 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34781-submit@debbugs.gnu.org id=B34781.155384929621987 (code B ref 34781); Fri, 29 Mar 2019 08:49:02 +0000 Original-Received: (at 34781) by debbugs.gnu.org; 29 Mar 2019 08:48:16 +0000 Original-Received: from localhost ([127.0.0.1]:35034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9nBP-0005iZ-M8 for submit@debbugs.gnu.org; Fri, 29 Mar 2019 04:48:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9nBN-0005iN-OQ for 34781@debbugs.gnu.org; Fri, 29 Mar 2019 04:48:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9nBH-0005e3-2L; Fri, 29 Mar 2019 04:48:07 -0400 Original-Received: from [176.228.60.248] (port=3561 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h9nBG-0002P0-88; Fri, 29 Mar 2019 04:48:06 -0400 In-reply-to: <3a02a3378a526c8706b33f36b85c003a82aa2aa1.camel@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Thu, 28 Mar 2019 22:51:39 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156915 Archived-At: > From: Mattias Engdegård > Date: Thu, 28 Mar 2019 22:51:39 +0100 > Cc: monnier@iro.umontreal.ca, 34781@debbugs.gnu.org In addition to Paul's comments: > +Since the size of fixnums varies between platforms, the new predicate > +'portable-fixnum-p' can be used to determine whether a number is > +a fixnum on any machine running the current Emacs version. This entry lacks a header. NEWS is viewed in Outline mode, so it should have headers that start with one or more '*' characters. Please add a header for this item, and please make it short enough to fit on a single line. Also, it is advisable to accompany user-visible changes with suitable changes in documentation, in this case the ELisp manual. If you do provide patches for the manuals, the NEWS entry should be marked with "+++" to indicate that all the documentation will have been updated when the patch is pushed. > +(defun portable-fixnum-p (object) > + "Return t if OBJECT is a fixnum on any machine running the current > +Emacs version." Suggest to rephrase: "Non-nil if OBJECT is a fixnum on any platform. The value will be nil if OBJECT is not a number, or if its value needs more bits than a fixnum can support on some platforms." > + DEFVAR_LISP ("most-positive-portable-fixnum", > + Vmost_positive_portable_fixnum, > + doc: /* The greatest integer that is represented efficiently > +on any machine running this version of Emacs. The first line of any doc string must not be a complete sentence. This is because apropos commands only display the first line of the doc string. So I suggest to reword: The largest integer representable as fixnum on any platform. > + DEFVAR_LISP ("most-negative-portable-fixnum", > + Vmost_negative_portable_fixnum, > + doc: /* The least integer that is represented efficiently > +on any machine running this version of Emacs. Similarly here. Thanks for working on this.