From: Eli Zaretskii <eliz@gnu.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: eggert@cs.ucla.edu, monnier@iro.umontreal.ca, 34781@debbugs.gnu.org
Subject: bug#34781: 27.0.50; integer in pcase sometimes compared by eq
Date: Fri, 29 Mar 2019 11:48:07 +0300 [thread overview]
Message-ID: <83bm1ujcc8.fsf@gnu.org> (raw)
In-Reply-To: <3a02a3378a526c8706b33f36b85c003a82aa2aa1.camel@acm.org> (message from Mattias Engdegård on Thu, 28 Mar 2019 22:51:39 +0100)
> From: Mattias Engdegård <mattiase@acm.org>
> Date: Thu, 28 Mar 2019 22:51:39 +0100
> Cc: monnier@iro.umontreal.ca, 34781@debbugs.gnu.org
In addition to Paul's comments:
> +Since the size of fixnums varies between platforms, the new predicate
> +'portable-fixnum-p' can be used to determine whether a number is
> +a fixnum on any machine running the current Emacs version.
This entry lacks a header. NEWS is viewed in Outline mode, so it
should have headers that start with one or more '*' characters.
Please add a header for this item, and please make it short enough to
fit on a single line.
Also, it is advisable to accompany user-visible changes with suitable
changes in documentation, in this case the ELisp manual. If you do
provide patches for the manuals, the NEWS entry should be marked with
"+++" to indicate that all the documentation will have been updated
when the patch is pushed.
> +(defun portable-fixnum-p (object)
> + "Return t if OBJECT is a fixnum on any machine running the current
> +Emacs version."
Suggest to rephrase:
"Non-nil if OBJECT is a fixnum on any platform.
The value will be nil if OBJECT is not a number, or if its value
needs more bits than a fixnum can support on some platforms."
> + DEFVAR_LISP ("most-positive-portable-fixnum",
> + Vmost_positive_portable_fixnum,
> + doc: /* The greatest integer that is represented efficiently
> +on any machine running this version of Emacs.
The first line of any doc string must not be a complete sentence.
This is because apropos commands only display the first line of the
doc string. So I suggest to reword:
The largest integer representable as fixnum on any platform.
> + DEFVAR_LISP ("most-negative-portable-fixnum",
> + Vmost_negative_portable_fixnum,
> + doc: /* The least integer that is represented efficiently
> +on any machine running this version of Emacs.
Similarly here.
Thanks for working on this.
next prev parent reply other threads:[~2019-03-29 8:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 15:13 bug#34781: 27.0.50; integer in pcase sometimes compared by eq Mattias Engdegård
[not found] ` <handler.34781.B.15519717565134.ack@debbugs.gnu.org>
2019-03-12 12:24 ` bug#34781: Acknowledgement (27.0.50; integer in pcase sometimes compared by eq) Mattias Engdegård
2019-03-16 19:09 ` bug#34781: 27.0.50; integer in pcase sometimes compared by eq Mattias Engdegård
2019-03-28 18:25 ` Paul Eggert
2019-03-28 19:47 ` Michael Heerdegen
2019-03-28 20:33 ` Paul Eggert
2019-03-28 21:30 ` Michael Heerdegen
2019-03-28 19:51 ` Mattias Engdegård
2019-03-28 20:30 ` Paul Eggert
2019-03-28 21:51 ` Mattias Engdegård
2019-03-28 22:10 ` Paul Eggert
2019-03-28 22:11 ` Stefan Monnier
2019-03-28 22:20 ` Mattias Engdegård
2019-03-28 22:38 ` Paul Eggert
2019-03-28 23:03 ` Mattias Engdegård
2019-03-29 8:48 ` Eli Zaretskii [this message]
2019-03-29 9:52 ` Mattias Engdegård
2019-03-29 12:33 ` Eli Zaretskii
2019-03-28 19:43 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bm1ujcc8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=34781@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=mattiase@acm.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).