From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35062: [PATCH v2] min_cols/rows is always 0, remove noop actions Date: Fri, 05 Apr 2019 10:05:14 +0300 Message-ID: <83bm1lc4ph.fsf@gnu.org> References: <87ef6lic84.fsf@gmail.com> <20190402002327.28219-1-Hi-Angel@yandex.ru> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="117453"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35062@debbugs.gnu.org To: Konstantin Kharlamov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 05 09:06:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hCIvX-000UOE-6r for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Apr 2019 09:06:15 +0200 Original-Received: from localhost ([127.0.0.1]:37262 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCIvW-00054w-4i for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Apr 2019 03:06:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34265) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCIvO-00054n-V2 for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2019 03:06:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hCIvM-0000M1-TX for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2019 03:06:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59706) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hCIvK-0000K3-Kt for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2019 03:06:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hCIvK-00079w-D8 for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2019 03:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Apr 2019 07:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35062 X-GNU-PR-Package: emacs Original-Received: via spool by 35062-submit@debbugs.gnu.org id=B35062.155444794027486 (code B ref 35062); Fri, 05 Apr 2019 07:06:02 +0000 Original-Received: (at 35062) by debbugs.gnu.org; 5 Apr 2019 07:05:40 +0000 Original-Received: from localhost ([127.0.0.1]:45017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCIuy-00079G-4X for submit@debbugs.gnu.org; Fri, 05 Apr 2019 03:05:40 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCIuv-000794-Vi for 35062@debbugs.gnu.org; Fri, 05 Apr 2019 03:05:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59025) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCIuq-00082B-Ja; Fri, 05 Apr 2019 03:05:32 -0400 Original-Received: from [176.228.60.248] (port=4940 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hCIun-0006s6-RG; Fri, 05 Apr 2019 03:05:30 -0400 In-reply-to: <20190402002327.28219-1-Hi-Angel@yandex.ru> (message from Konstantin Kharlamov on Tue, 2 Apr 2019 03:23:27 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157207 Archived-At: > From: Konstantin Kharlamov > Date: Tue, 2 Apr 2019 03:23:27 +0300 > > * src/gtkutil.c: > remove "always false" comparison > remove multiplication by zero, it's a noop anyway > remove min_cols and min_rows as it's now unused > > Fixes LGTM warnings: > * Comparison is always false because min_cols <= 0. > * Comparison is always false because min_rows <= 0. > --- > v2: remove the min_rows/min_cols whatsoever Thanks, pushed. Please in the future write the commit log messages in the ChangeLog-like style, see CONTRIBUTE for the details. I did that this time, you can look at what I pushed to see an example of that style in action.