From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35238: 27.0.50; Clarify eventp behaviour with booleans Date: Fri, 12 Apr 2019 15:30:42 +0300 Message-ID: <83bm1bmmml.fsf@gnu.org> References: <87pnpsp3jd.fsf@tcd.ie> <87y34fscl6.fsf@tcd.ie> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="153751"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35238@debbugs.gnu.org, monnier@IRO.UMontreal.CA To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 12 14:47:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hEvaM-000dnS-7Y for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Apr 2019 14:47:14 +0200 Original-Received: from localhost ([127.0.0.1]:35962 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEvaL-0006bo-4G for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Apr 2019 08:47:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEvLf-0000O5-Ua for bug-gnu-emacs@gnu.org; Fri, 12 Apr 2019 08:32:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEvLf-0007kT-56 for bug-gnu-emacs@gnu.org; Fri, 12 Apr 2019 08:32:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42035) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hEvLe-0007kE-Te for bug-gnu-emacs@gnu.org; Fri, 12 Apr 2019 08:32:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hEvLe-0002Fk-J0 for bug-gnu-emacs@gnu.org; Fri, 12 Apr 2019 08:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Apr 2019 12:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35238 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35238-submit@debbugs.gnu.org id=B35238.15550722708593 (code B ref 35238); Fri, 12 Apr 2019 12:32:02 +0000 Original-Received: (at 35238) by debbugs.gnu.org; 12 Apr 2019 12:31:10 +0000 Original-Received: from localhost ([127.0.0.1]:55579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEvKn-0002EX-TA for submit@debbugs.gnu.org; Fri, 12 Apr 2019 08:31:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEvKm-0002EK-J7 for 35238@debbugs.gnu.org; Fri, 12 Apr 2019 08:31:08 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59251) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEvKg-0006wM-UM; Fri, 12 Apr 2019 08:31:03 -0400 Original-Received: from [176.228.60.248] (port=2048 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hEvKe-0002dj-JP; Fri, 12 Apr 2019 08:31:01 -0400 In-reply-to: <87y34fscl6.fsf@tcd.ie> (contovob@tcd.ie) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157548 Archived-At: > From: "Basil L. Contovounesios" > Date: Fri, 12 Apr 2019 12:11:01 +0100 > Cc: 35238@debbugs.gnu.org > > -(defun eventp (obj) > - "True if the argument is an event object." > - (when obj > - (or (integerp obj) > - (and (symbolp obj) obj (not (keywordp obj))) > - (and (consp obj) (symbolp (car obj)))))) > +(defun eventp (object) > + "Return non-nil if OBJECT is an input event or event object." > + (or (integerp object) > + (and (symbolp (if (consp object) > + (setq object (car object)) > + object)) > + (not (keywordp object))))) Please make sure the ELisp manual is kept in sync. Also, does this need to be called out in NEWS?