From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31946: 27.0.50; The NSM should warn about more TLS problems Date: Mon, 26 Aug 2019 21:12:53 +0300 Message-ID: <83blwbg5i2.fsf@gnu.org> References: <87h8647de5.fsf@gnus.org> <86tva4dq8h.fsf@gmail.com> <83k1azgbbi.fsf@gnu.org> <86zhjvrfbp.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="194597"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 31946@debbugs.gnu.org To: Andy Moreton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 26 20:13:29 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i2JUc-000oSY-Iv for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Aug 2019 20:13:26 +0200 Original-Received: from localhost ([::1]:56372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2JUb-00006i-Hh for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Aug 2019 14:13:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55835) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2JUF-00006M-Dk for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 14:13:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i2JUE-0003q0-Ed for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 14:13:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38383) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i2JUE-0003ps-Bf for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 14:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i2JUE-0007lD-4S for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 14:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Aug 2019 18:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31946 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security fixed Original-Received: via spool by 31946-submit@debbugs.gnu.org id=B31946.156684317929821 (code B ref 31946); Mon, 26 Aug 2019 18:13:02 +0000 Original-Received: (at 31946) by debbugs.gnu.org; 26 Aug 2019 18:12:59 +0000 Original-Received: from localhost ([127.0.0.1]:47204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2JUA-0007ku-Ty for submit@debbugs.gnu.org; Mon, 26 Aug 2019 14:12:59 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47327) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2JU9-0007ka-8H for 31946@debbugs.gnu.org; Mon, 26 Aug 2019 14:12:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44475) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i2JU4-0003fi-60; Mon, 26 Aug 2019 14:12:52 -0400 Original-Received: from [176.228.60.248] (port=2914 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i2JU3-0007Dz-8D; Mon, 26 Aug 2019 14:12:51 -0400 In-reply-to: <86zhjvrfbp.fsf@gmail.com> (message from Andy Moreton on Mon, 26 Aug 2019 18:45:14 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165917 Archived-At: > From: Andy Moreton > Date: Mon, 26 Aug 2019 18:45:14 +0100 > > > That's because any memory allocated by GnuTLS cannot be freed by Emacs > > via 'free' or 'xfree', it needs to be freed by calling 'gnutls_free' > > (the GnuTLS manual clearly says that, btw). That crashes, because on > > Windows we use our own implementation of 'free', which uses a > > different heap. > > Agreed, but master built from commit 1071a4f still crashes in the same > way: Can you show a recipe? > In Fgnutls_format_certificate, should out_buf be freed after calling > build_string ? I see no problem with that, since build_string copies the data. > Removing both xfree(out.data) and xfree(out_buf) from the end of > that function does give me a running emacs. It may run, but it leaks memory.