bug#37236: 25.1; dired fails on pCloud drive

bug#37236: 25.1; dired fails on pCloud drive

[Damon Permezel]

M-x dired ~/pCloud\ Drive

Debugger entered--Lisp error: (wrong-type-argument consp nil)
  ls-lisp-sanitize(((".VolumeIcon.icns" nil 1 "dap" "wheel" (23900 56314 0 0) (23900 56314 0 0) (23900 56314 0 0) 1708546 "-r--r--r--" t 53210 855638019) (".DS_Store" nil 1 "dap" "staff" (23911 33443 0 0) (23911 33443 0 0) (23911 33443 0 0) 8196 "-rw-r--r--" t 53136 855638019) ("Getting started with pCloud.pdf" nil 1 "dap" "staff" (23894 11575 0 0) (23894 11575 0 0) (23894 11575 0 0) 22442353 "-rw-r--r--" t 53209 855638019) ("Public Folder" t 2 "dap" "staff" (23911 34577 0 0) (23911 34577 0 0) (23911 34577 0 0) 4096 "drwxr-xr-x" t 53208 855638019) ("Crypto Folder" t 3 "dap" "staff" (23912 55020 0 0) (23912 55020 0 0) (23912 55020 0 0) 4096 "drwxr-xr-x" t 53112 855638019) ("CryptoMator" t 3 "dap" "staff" (23899 61629 0 0) (23899 61629 0 0) (23899 61629 0 0) 4096 "drwxr-xr-x" t 53107 855638019) ("rclone" t 5 "dap" "staff" (23894 12721 0 0) (23894 12721 0 0) (23894 12721 0 0) 4096 "drwxr-xr-x" t 308 855638019) ("My Videos" t 2 "dap" "staff" (23894 11575 0 0) (23894 11575 0 0) (23894 11575 0 0) 4096 "drwxr-xr-x" t 53207 855638019) ("My Pictures" t 2 "dap" "staff" (23894 11575 0 0) (23894 11575 0 0) (23894 11575 0 0) 4096 "drwxr-xr-x" t 53206 855638019) ("My Music" t 2 "dap" "staff" (23894 11575 0 0) (23894 11575 0 0) (23894 11575 0 0) 4096 "drwxr-xr-x" t 53205 855638019) ("." t 9 "dap" "staff" (23911 34577 0 0) (23911 34577 0 0) (23911 34577 0 0) 4096 "drwxr-xr-x" t 1 855638019)))
  ls-lisp-insert-directory("/Users/dap/pCloud Drive/" (97 108) nil nil t)
  ls-lisp--insert-directory(#[...

  insert-directory("/Users/dap/pCloud Drive/" "-al" nil t)
  dired-insert-directory("/Users/dap/pCloud Drive/" "-al" nil nil t)
  dired-readin-insert()
  dired-readin()
  dired-internal-noselect("~/pCloud Drive/" nil)
  dired-noselect("~/pCloud Drive/" nil)
  dired("~/pCloud Drive/" nil)
  funcall-interactively(dired "~/pCloud Drive/" nil)
  call-interactively(dired record nil)
  command-execute(dired record)
  execute-extended-command(nil "dired" nil)
  funcall-interactively(execute-extended-command nil "dired" nil)
  call-interactively(execute-extended-command nil nil)
  command-execute(execute-extended-command)




In GNU Emacs 25.1.1 (x86_64-apple-darwin13.4.0, NS appkit-1265.21 Version 10.9.5 (Build 13F1911))
of 2016-09-21 built on builder10-9.porkrind.org
Windowing system distributor 'Apple', version 10.3.1671
Configured using:
'configure --with-ns '--enable-locallisppath=/Library/Application
Support/Emacs/${version}/site-lisp:/Library/Application
Support/Emacs/site-lisp' --with-modules'

Configured features:
NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Apropos

Minor modes in effect:
  shell-dirtrack-mode: t
  show-paren-mode: t
  display-time-mode: t
  minibuffer-electric-default-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
Mark saved where search started
Type "q" in help window to restore its previous buffer.

Load-path shadows:
~/DotFiles/emacs/maclib/cc-mode-5.32.5/cc-guess hides /Applications/Emacs.app/Contents/Resources/lisp/progmodes/cc-guess
~/DotFiles/emacs/maclib/cc-mode-5.32.5/cc-styles hides /Applications/Emacs.app/Contents/Resources/lisp/progmodes/cc-styles
~/DotFiles/emacs/maclib/cc-mode-5.32.5/cc-engine hides /Applications/Emacs.app/Contents/Resources/lisp/progmodes/cc-engine
~/DotFiles/emacs/maclib/cc-mode-5.32.5/cc-vars hides /Applications/Emacs.app/Contents/Resources/lisp/progmodes/cc-vars
~/DotFiles/emacs/maclib/cc-mode-5.32.5/cc-align hides /Applications/Emacs.app/Contents/Resources/lisp/progmodes/cc-align
~/DotFiles/emacs/maclib/cc-mode-5.32.5/cc-menus hides /Applications/Emacs.app/Contents/Resources/lisp/progmodes/cc-menus
~/DotFiles/emacs/maclib/cc-mode-5.32.5/cc-cmds hides /Applications/Emacs.app/Contents/Resources/lisp/progmodes/cc-cmds
~/DotFiles/emacs/maclib/cc-mode-5.32.5/cc-awk hides /Applications/Emacs.app/Contents/Resources/lisp/progmodes/cc-awk
~/DotFiles/emacs/maclib/cc-mode-5.32.5/cc-mode hides /Applications/Emacs.app/Contents/Resources/lisp/progmodes/cc-mode
~/DotFiles/emacs/maclib/cc-mode-5.32.5/cc-langs hides /Applications/Emacs.app/Contents/Resources/lisp/progmodes/cc-langs
~/DotFiles/emacs/maclib/cc-mode-5.32.5/cc-bytecomp hides /Applications/Emacs.app/Contents/Resources/lisp/progmodes/cc-bytecomp
~/DotFiles/emacs/maclib/cc-mode-5.32.5/cc-defs hides /Applications/Emacs.app/Contents/Resources/lisp/progmodes/cc-defs
~/DotFiles/emacs/maclib/ruby-mode hides /Applications/Emacs.app/Contents/Resources/lisp/progmodes/ruby-mode
~/DotFiles/emacs/maclib/cc-mode-5.32.5/cc-fonts hides /Applications/Emacs.app/Contents/Resources/lisp/progmodes/cc-fonts
/Users/dap/.emacs.d/elpa/seq-2.20/seq hides /Applications/Emacs.app/Contents/Resources/lisp/emacs-lisp/seq
~/DotFiles/emacs/maclib/cc-mode-5.32.5/cc-compat hides /Applications/Emacs.app/Contents/Resources/lisp/obsolete/cc-compat

Features:
(shadow sort mail-extr emacsbug message format-spec rfc822 mml mml-sec
password-cache epg gnus-util mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils help-fns misearch multi-isearch
apropos dabbrev shell pcomplete debug spell-number exec-path-from-shell
cl-macs easy-mmode cus-edit cus-start cus-load wid-edit paren globalff
flyspell ispell time minibuf-eldef xcscope ruby-electric ruby-mode
compile info ehelp echistory chistory ebuff-menu hippie-exp comint
ansi-color ring edmacro kmacro cc-mode cc-fonts cc-guess cc-menus
cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs ls-lisp .loaddefs
el-get el-get-autoloading el-get-list-packages el-get-dependencies
el-get-build el-get-status pp el-get-methods el-get-fossil el-get-svn
el-get-pacman el-get-github-zip el-get-github-tar el-get-http-zip
el-get-http-tar el-get-hg el-get-go el-get-git-svn el-get-fink
el-get-emacswiki el-get-http el-get-notify el-get-emacsmirror
el-get-github el-get-git el-get-elpa el-get-darcs el-get-cvs el-get-bzr
el-get-brew el-get-builtin el-get-apt-get el-get-recipes
el-get-byte-compile subr-x el-get-custom cl-seq el-get-core autoload
lisp-mnt cl dired finder-inf package epg-config seq byte-opt gv bytecomp
byte-compile cl-extra help-mode easymenu cconv cl-loaddefs pcase cl-lib
time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel ns-win ucs-normalize term/common-win tool-bar dnd
fontset image regexp-opt fringe tabulated-list newcomment elisp-mode
lisp-mode prog-mode register page menu-bar rfn-eshadow timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame
cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai
tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian
slovak czech european ethiopic indian cyrillic chinese charscript
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote kqueue cocoa ns
multi-tty make-network-process emacs)

Memory information:
((conses 16 287190 7289)
(symbols 48 28338 0)
(miscs 40 160 416)
(strings 32 44129 9253)
(string-bytes 1 1336441)
(vectors 16 43023)
(vector-slots 8 768384 2363)
(floats 8 235 275)
(intervals 56 751 0)
(buffers 976 24))

bug#37236: 25.1; dired fails on pCloud drive

[Eli Zaretskii]

> From: Damon Permezel <dap@zepherin.com>
> Date: Fri, 30 Aug 2019 18:14:03 +1000
> 
> M-x dired ~/pCloud\ Drive
> 
> Debugger entered--Lisp error: (wrong-type-argument consp nil)
>   ls-lisp-sanitize(((".VolumeIcon.icns" nil 1 "dap" "wheel" (23900 56314 0 0) (23900 56314 0 0) (23900 56314 0 0) 1708546 "-r--r--r--" t 53210 855638019) (".DS_Store" nil 1 "dap" "staff" (23911 33443 0 0) (23911 33443 0 0) (23911 33443 0 0) 8196 "-rw-r--r--" t 53136 855638019) ("Getting started with pCloud.pdf" nil 1 "dap" "staff" (23894 11575 0 0) (23894 11575 0 0) (23894 11575 0 0) 22442353 "-rw-r--r--" t 53209 855638019) ("Public Folder" t 2 "dap" "staff" (23911 34577 0 0) (23911 34577 0 0) (23911 34577 0 0) 4096 "drwxr-xr-x" t 53208 855638019) ("Crypto Folder" t 3 "dap" "staff" (23912 55020 0 0) (23912 55020 0 0) (23912 55020 0 0) 4096 "drwxr-xr-x" t 53112 855638019) ("CryptoMator" t 3 "dap" "staff" (23899 61629 0 0) (23899 61629 0 0) (23899 61629 0 0) 4096 "drwxr-xr-x" t 53107 85563
 8019) ("rclone" t 5 "dap" "staff" (23894 12721 0 0) (23894 12721 0 0) (23894 12721 0 0) 4096 "drwxr-xr-x" t 308 855638019) ("My Videos" t 2 "dap" "staff" (23894 11575 0 0) (23894 11575 0 0) (23894 11575 0 0) 4096 "drwxr-xr-x" t 53207 855638019) ("My Pictures" t 2 "dap" "staff" (23894 11575 0 0) (23894 11575 0 0) (23894 11575 0 0) 4096 "drwxr-xr-x" t 53206 855638019) ("My Music" t 2 "dap" "staff" (23894 11575 0 0) (23894 11575 0 0) (23894 11575 0 0) 4096 "drwxr-xr-x" t 53205 855638019) ("." t 9 "dap" "staff" (23911 34577 0 0) (23911 34577 0 0) (23911 34577 0 0) 4096 "drwxr-xr-x" t 1 855638019)))
>   ls-lisp-insert-directory("/Users/dap/pCloud Drive/" (97 108) nil nil t)
>   ls-lisp--insert-directory(#[...

ls-lisp isn't prepared for a situation where a directory has a "."
entry, but doesn't have a ".." entry.

Does the patch below fix the problem?

diff --git a/lisp/ls-lisp.el b/lisp/ls-lisp.el
index e802c24..8491181 100644
--- a/lisp/ls-lisp.el
+++ b/lisp/ls-lisp.el
@@ -517,7 +517,8 @@ ls-lisp-sanitize
 are copied from the \".\" entry, if they are non-nil.  Otherwise,
 the offending element is removed from the list, as are any
 elements for other directory entries with nil attributes."
-  (if (and (null (cdr (assoc ".." file-alist)))
+  (if (and (consp (assoc ".." file-alist))
+           (null (cdr (assoc ".." file-alist)))
 	   (cdr (assoc "." file-alist)))
       (setcdr (assoc ".." file-alist) (cdr (assoc "." file-alist))))
   (rassq-delete-all nil file-alist))

bug#37236: 25.1; dired fails on pCloud drive

[Damon Permezel]

[-- Attachment #1.1: Type: text/plain, Size: 306 bytes --]

That does indeed address the issue.
Thanks for that!

> On 31 Aug 2019, at 01:20, Eli Zaretskii <eliz@gnu.org> wrote:
> 
> -  (if (and (null (cdr (assoc ".." file-alist)))
> +  (if (and (consp (assoc ".." file-alist))
> +           (null (cdr (assoc ".." file-alist)))
> 	   (cdr (assoc "." file-alist)))


[-- Attachment #1.2: Type: text/html, Size: 4122 bytes --]

[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#37236: 25.1; dired fails on pCloud drive

[Eli Zaretskii]

> From: Damon Permezel <dap@zepherin.com>
> Date: Sat, 31 Aug 2019 16:41:20 +1000
> Cc: 37236@debbugs.gnu.org
> 
> That does indeed address the issue.

Thanks, I installed the change on the master branch, and I'm closing
this bug report.

bug#37236: 25.1; dired fails on pCloud drive

[Damon Permezel]

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]

On 31 Aug 2019, at 16:56, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> From: Damon Permezel <dap@zepherin.com>
>> Date: Sat, 31 Aug 2019 16:41:20 +1000
>> Cc: 37236@debbugs.gnu.org
>> 
>> That does indeed address the issue.
> 
> Thanks, I installed the change on the master branch, and I'm closing
> this bug report.

Thank you.



[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]