From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Wed, 16 Oct 2019 10:53:21 +0300 Message-ID: <83bluhf7nz.fsf@gnu.org> References: Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="4372"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Ergus , 37774@debbugs.gnu.org To: Andrey Orst Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 16 09:54:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKe8S-0000wa-D1 for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 09:54:20 +0200 Original-Received: from localhost ([::1]:38532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKe8R-0005v3-5M for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 03:54:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41085) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKe8D-0005sH-Ol for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 03:54:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKe8B-0005Dl-SA for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 03:54:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36340) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKe8A-0005D5-7X for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 03:54:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKe8A-0006n8-3P for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 03:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Oct 2019 07:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157121243026087 (code B ref 37774); Wed, 16 Oct 2019 07:54:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 16 Oct 2019 07:53:50 +0000 Original-Received: from localhost ([127.0.0.1]:45161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKe7w-0006mb-HI for submit@debbugs.gnu.org; Wed, 16 Oct 2019 03:53:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60139) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKe7u-0006mN-Ac for 37774@debbugs.gnu.org; Wed, 16 Oct 2019 03:53:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37271) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iKe7p-00050I-48; Wed, 16 Oct 2019 03:53:41 -0400 Original-Received: from [176.228.60.248] (port=3655 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iKe7o-0002Mm-GQ; Wed, 16 Oct 2019 03:53:40 -0400 In-reply-to: (message from Andrey Orst on Wed, 16 Oct 2019 10:00:38 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169421 Archived-At: > From: Andrey Orst > Date: Wed, 16 Oct 2019 10:00:38 +0300 > > Somewhat last checkout from master brought the change of face > attributes, adding new `:extend` attribute, which make all themes, and > packages like Magit display weirdly. By this I mean that before the > change, some faces were set up to extend highlighting beyond EOL, but > now all of those faces are not doing this. I've first reported this to > the theme package I'm using: > https://github.com/hlissner/emacs-doom-themes/issues/342 but I think > that this should be handled by emacs itself, because if not it will > result in the duplicated or extra code in themes fro different Emacs > versions. This reddit post has some screenshots of what I mean: > https://www.reddit.com/r/emacs/comments/diahh1/emacs_27_update_changed_how_highlighted_lines/ The screenshots you posted don't clearly explain the problem. Some of them seem actually identical before and after the change, and with others I don't think I see the problem. So please explain what exactly is incorrect or "weird" in the visual appearance after the change. Specifically, why the faces in question need to be extended past EOL? Thanks.