From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Thu, 14 Nov 2019 13:33:43 +0200 Message-ID: <83blte7kvc.fsf@gnu.org> References: <87o8xwrjba.fsf@bernoul.li> <834kzooo8e.fsf@gnu.org> <877e4d7yzf.fsf@bernoul.li> <83imnvg53q.fsf@gnu.org> <87zhh2ofc9.fsf@bernoul.li> <87k186nsku.fsf@bernoul.li> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="32021"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37774@debbugs.gnu.org To: Jonas Bernoulli Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 14 12:35:25 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVDPF-00087q-Sh for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Nov 2019 12:35:22 +0100 Original-Received: from localhost ([::1]:56266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVDPE-00085U-Lq for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Nov 2019 06:35:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35150) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVDP0-000857-B3 for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2019 06:35:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVDOx-00062S-V2 for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2019 06:35:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52210) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iVDOv-00062C-WB for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2019 06:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iVDOv-0002YV-PR for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2019 06:35:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Nov 2019 11:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.15737312489758 (code B ref 37774); Thu, 14 Nov 2019 11:35:01 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 14 Nov 2019 11:34:08 +0000 Original-Received: from localhost ([127.0.0.1]:32798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVDO4-0002XK-F1 for submit@debbugs.gnu.org; Thu, 14 Nov 2019 06:34:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVDO2-0002Wv-GN for 37774@debbugs.gnu.org; Thu, 14 Nov 2019 06:34:07 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iVDNw-0005jP-Hm; Thu, 14 Nov 2019 06:34:00 -0500 Original-Received: from [176.228.60.248] (port=3041 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iVDNv-0005G0-UZ; Thu, 14 Nov 2019 06:34:00 -0500 In-reply-to: <87k186nsku.fsf@bernoul.li> (message from Jonas Bernoulli on Mon, 11 Nov 2019 20:03:45 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171581 Archived-At: > From: Jonas Bernoulli > Cc: 37774@debbugs.gnu.org > Date: Mon, 11 Nov 2019 20:03:45 +0100 > > Then enable any theme and notice how the highlighting no longer extends > to the edge of the window. > > That's because the theme does something like: > '(hl-line ((t (:background "lightgrey")))) > as opposed to > '(hl-line ((t (:background "lightgrey" :extend t)))) > > I mentioned this elsewhere and Dmitry said that this is not how it is > supposed to work and if it did work that way then that would be a bug. > > He also mentioned that this had been discussed here but I have been > reading this issue from the top while listening to all the way to > "The End" of the The Very Best Of The Doors and I still have not read > anything about something being done to prevent the need to repeat the > extend setting. Message #104 mentions a variation of this issue, but > so far I haven't gotten to a message saying "okay lets add a hack to > deal with this" yet, so I figured I would ask: > > Should it be unnecessary that each and every theme does: > - '(hl-line ((t (:background "lightgrey")))) > + '(hl-line ((t (:background "lightgrey" :extend t)))) > ? How is :extend different from any other face attribute? The documentation of custom-theme-set-faces says that FACE should be a face spec, like in defface. And the latter does override all the attributes, unless it uses :inherit. So I'm not unsure why you expected something else. AFAIU, we should now modify all the themes that come with Emacs to use :extend for those faces whose default spec does.