From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Sat, 30 Nov 2019 13:35:23 +0200 Message-ID: <83blstoav8.fsf@gnu.org> References: <87o8xwrjba.fsf@bernoul.li> <834kzooo8e.fsf@gnu.org> <877e4d7yzf.fsf@bernoul.li> <83imnvg53q.fsf@gnu.org> <87zhh2ofc9.fsf@bernoul.li> <87k186nsku.fsf@bernoul.li> <87imna18nc.fsf@mail.linkov.net> <42c596c2-b5c1-9fc9-4b92-9c13b386d93d@yandex.ru> <83pnhgrlni.fsf@gnu.org> <87d0dd88jr.fsf@mail.linkov.net> <83pnhcowtz.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="250452"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37774@debbugs.gnu.org, dgutov@yandex.ru To: juri@linkov.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 30 12:36:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ib12n-001322-Lk for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Nov 2019 12:36:09 +0100 Original-Received: from localhost ([::1]:39756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ib12m-0008Sa-H2 for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Nov 2019 06:36:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48334) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ib12g-0008SS-UT for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2019 06:36:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ib12f-0006Hj-SP for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2019 06:36:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56059) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ib12f-0006Hb-Om for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2019 06:36:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ib12f-0003Ss-L3 for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2019 06:36:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Nov 2019 11:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157511375213302 (code B ref 37774); Sat, 30 Nov 2019 11:36:01 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 30 Nov 2019 11:35:52 +0000 Original-Received: from localhost ([127.0.0.1]:33799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ib12W-0003SU-2w for submit@debbugs.gnu.org; Sat, 30 Nov 2019 06:35:52 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39249) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ib12T-0003SH-UO for 37774@debbugs.gnu.org; Sat, 30 Nov 2019 06:35:50 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33737) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ib12O-0005ru-Fj; Sat, 30 Nov 2019 06:35:44 -0500 Original-Received: from [176.228.60.248] (port=2230 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ib12I-0001b8-1S; Sat, 30 Nov 2019 06:35:40 -0500 In-reply-to: <83pnhcowtz.fsf@gnu.org> (message from Eli Zaretskii on Thu, 28 Nov 2019 17:16:24 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172679 Archived-At: > Date: Thu, 28 Nov 2019 17:16:24 +0200 > From: Eli Zaretskii > Cc: 37774@debbugs.gnu.org, dgutov@yandex.ru > > > >> We need to modify all the themes we provide to specify :extend for > > >> faces where we do that by default. It seems there's no way around > > >> that, since the semantics of custom-theme-set-faces is clearly to > > >> reset all face attributes to 'unspecified' before applying the face > > >> spec, so keeping some attributes from the default face spec is out of > > >> the question, unfortunately. It's clear that the faces stuff was not > > >> designed to accommodate addition of attributes easily. > > > > This means manually adding :extend to all files in etc/themes? > > Yes. I've now done that. Two comments: . When adding the :extend attribute to a face, we should make sure all of that face's definitions have the same value of it, even if the default definition of the face for some 'class' of displays doesn't need it (e.g., because it specifies only the foreground color). This is so that if users customize the face, the results will look uniform regardless of which face attributes they customize. Otherwise, if the user customizes the background color or :underline or some other similar attribute, the appearance will be different from that on other classes of terminals, and that is baaaad... . Some of the themes we have in core customize faces defined by unbundled packages. I didn't change the definitions of those faces; it's up to the respective package developers and/or users to come up and ask for such changes, if it turns out the packages added the :extend attribute and we didn't.