unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: yyoncho@gmail.com, 38406@debbugs.gnu.org
Subject: bug#38406: 27.0.50; post-self-insert-hook does not hold its contract in cc-mode derived modes
Date: Sun, 01 Dec 2019 22:47:01 +0200	[thread overview]
Message-ID: <83blsrn58a.fsf@gnu.org> (raw)
In-Reply-To: <20191201192709.GE5085@ACM> (message from Alan Mackenzie on Sun,  1 Dec 2019 19:27:09 +0000)

> Date: Sun, 1 Dec 2019 19:27:09 +0000
> Cc: yyoncho@gmail.com, 38406@debbugs.gnu.org
> From: Alan Mackenzie <acm@muc.de>
> 
> post-self-insert-hook's functions, unusually amongs hooks, interfere with
> its triggering event.  This contrasts with, say, after-change-functions,
> where the functions don't insert into or delete from the buffer, or
> pre-redisplay-functions, where the functions don't try to prevent a
> particular window getting displayed.

You'd be surprised to know what some of those hooks do.  Everything
you say they don't, and then some.  There's nothing we can do to
prevent people from shooting themselves in the foot or hanging
themselves with the rope we provided.  And if you think you are the
only one who needs to harden your code to let people do the craziest
things with these hooks, please don't think so: you are definitely
not alone.

But breaking a hook's contract as a means to teach people not to shoot
themselves in the foot is not right.  If the uses are legitimate, they
should be able to do them; if they aren't, let them cope with the
consequences.

> So to call this hook at the end of c-electric-brace would mean having to
> filter the hook first (at the very least, to remove
> electric-pair-post-self-insert-function), which just seems very hackish
> and unsatisfactory.

It doesn't seem too hackish to me, and as a nice bonus we will have
post-self-insert-hook act as per its contract again.

So could you please do that?  TIA.





  reply	other threads:[~2019-12-01 20:47 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-27 20:00 bug#38406: 27.0.50; post-self-insert-hook does not hold its contract in cc-mode derived modes yyoncho
2019-11-30 14:36 ` Alan Mackenzie
2019-12-01 10:02   ` yyoncho
2019-12-01 15:07     ` Alan Mackenzie
2019-12-01 15:27       ` yyoncho
2019-12-01 15:58         ` Alan Mackenzie
2019-12-01 18:03           ` Eli Zaretskii
2019-12-02 18:37             ` Alan Mackenzie
2019-12-01 17:59       ` Eli Zaretskii
2019-12-01 19:27         ` Alan Mackenzie
2019-12-01 20:47           ` Eli Zaretskii [this message]
2019-12-02 18:31             ` Alan Mackenzie
2019-12-02 20:17               ` Eli Zaretskii
2019-12-04 20:41             ` Alan Mackenzie
2019-12-04 21:04               ` Dmitry Gutov
2019-12-05 19:14                 ` Alan Mackenzie
2019-12-05 20:44                   ` Dmitry Gutov
2019-12-05 14:45               ` Eli Zaretskii
2019-12-05 19:09                 ` Alan Mackenzie
2019-12-05 19:25                   ` Eli Zaretskii
2019-12-05 20:17                     ` Alan Mackenzie
2019-12-06  8:06                       ` Eli Zaretskii
2019-12-06 18:28                         ` Alan Mackenzie
2019-12-06 18:48                           ` Eli Zaretskii
2019-12-06 22:24                             ` Alan Mackenzie
2019-12-07  8:21                               ` Eli Zaretskii
2019-12-07 11:40                                 ` Alan Mackenzie
2019-12-07 13:27                                   ` Eli Zaretskii
2019-12-07 19:03                                     ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83blsrn58a.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=38406@debbugs.gnu.org \
    --cc=acm@muc.de \
    --cc=yyoncho@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).