From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38492: 27.0.50; Warn pdumper users when pure space has been overflowed Date: Fri, 06 Dec 2019 10:12:44 +0200 Message-ID: <83blslhnyb.fsf@gnu.org> References: <87o8wnj4nf.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="18705"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38492@debbugs.gnu.org To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec , Daniel Colascione Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 06 18:37:41 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1idHXw-0004ge-O1 for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Dec 2019 18:37:40 +0100 Original-Received: from localhost ([::1]:42224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idHXu-0004LO-DB for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Dec 2019 12:37:38 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51245) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idGK1-0005uZ-QV for bug-gnu-emacs@gnu.org; Fri, 06 Dec 2019 11:19:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1idGK0-0003An-EX for bug-gnu-emacs@gnu.org; Fri, 06 Dec 2019 11:19:13 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40972) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1idGK0-000358-6B for bug-gnu-emacs@gnu.org; Fri, 06 Dec 2019 11:19:12 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1idGGz-000550-Ky for bug-gnu-emacs@gnu.org; Fri, 06 Dec 2019 11:16:05 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Dec 2019 16:16:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38492 X-GNU-PR-Package: emacs Original-Received: via spool by 38492-submit@debbugs.gnu.org id=B38492.157564894519376 (code B ref 38492); Fri, 06 Dec 2019 16:16:05 +0000 Original-Received: (at 38492) by debbugs.gnu.org; 6 Dec 2019 16:15:45 +0000 Original-Received: from localhost ([127.0.0.1]:46927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idGGe-00052P-P6 for submit@debbugs.gnu.org; Fri, 06 Dec 2019 11:15:45 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57017) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idGGa-00050y-2c for 38492@debbugs.gnu.org; Fri, 06 Dec 2019 11:15:41 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43185) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1idGGN-0002J4-BE; Fri, 06 Dec 2019 11:15:27 -0500 Original-Received: from [176.228.60.248] (port=2445 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1id8jF-0003fM-Bp; Fri, 06 Dec 2019 03:12:45 -0500 In-reply-to: <87o8wnj4nf.fsf@gmail.com> (message from =?UTF-8?Q?K=C3=A9vin?= Le Gouguec on Wed, 04 Dec 2019 20:02:12 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172964 Archived-At: > From: Kévin Le Gouguec > Date: Wed, 04 Dec 2019 20:02:12 +0100 > > For some reason, one of my setups[1] experiences a pure storage overflow > with the current master[2]. Searching previous bug reports for the > warning[3] led me to understand that increasing BASE_PURESIZE in > src/puresize.h would solve the issue; since I didn't have the patience > to recompile possibly multiple times, I tried to find a way to know > exactly how much I should increase this value. > > I noticed that Fdump_emacs uses check_pure_size from alloc.c to print a > warning before dumping when this happens. The following patch exposes > check_pure_size when we HAVE_PDUMPER, so that Fdump_emacs_portable can > use it too. I'm not sure we should care about overflowing the pure space in pdumped Emacs. Why does it matter? It mattered in unexec'ed Emacs, that's why we warned about it. Maybe the right solution is to remove the warning from startup.el instead. Daniel, what are your thoughts about this?