unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#39353: [PATCH] Use current-prefix-arg instead of prefix-arg
@ 2020-01-30  3:35 Kyle Hubert
  2020-01-30  3:53 ` Kyle Hubert
  2020-01-31 14:29 ` bug#39353: [PATCH] Ediff fix for ediff-scroll-horizontally Kyle Hubert
  0 siblings, 2 replies; 7+ messages in thread
From: Kyle Hubert @ 2020-01-30  3:35 UTC (permalink / raw)
  To: 39353; +Cc: Kyle Hubert

Forwarding arguments through to children function invocations should
be handled by current-prefix-arg. This was first uncovered when ediff
used full window width scrolling in ediff-scroll-horizontally, when
the call to scroll-left or scroll-right should have been half-window
size. Through further grepping, there was another usage in
simple.el. Note, execute-extended-command was visually inspected that
it was in interactive mode.

---
 lisp/simple.el        | 2 +-
 lisp/vc/ediff-util.el | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lisp/simple.el b/lisp/simple.el
index 2ec3da680f..53afa7b138 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -1888,7 +1888,7 @@ invoking, give a prefix argument to `execute-extended-command'."
     ;; `function' and not `execute-extended-command'.  The difference is
     ;; visible in cases such as M-x <cmd> RET and then C-x z (bug#11506).
     (setq real-this-command function)
-    (let ((prefix-arg prefixarg))
+    (let ((current-prefix-arg prefixarg))
       (command-execute function 'record))
     ;; If enabled, show which key runs this command.
     ;; But first wait, and skip the message if there is input.
diff --git a/lisp/vc/ediff-util.el b/lisp/vc/ediff-util.el
index a8af9ba37a..5f8a4a86b1 100644
--- a/lisp/vc/ediff-util.el
+++ b/lisp/vc/ediff-util.el
@@ -1540,10 +1540,10 @@ the width of the A/B/C windows."
    ;; hscrolling.
    (if (= last-command-event ?<)
        (lambda (arg)
-	 (let ((prefix-arg arg))
+	 (let ((current-prefix-arg arg))
 	   (call-interactively #'scroll-left)))
      (lambda (arg)
-       (let ((prefix-arg arg))
+       (let ((current-prefix-arg arg))
 	 (call-interactively #'scroll-right))))
    ;; calculate argument to scroll-left/right
    ;; if there is an explicit argument
-- 
2.25.0






^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-02-08 10:01 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-30  3:35 bug#39353: [PATCH] Use current-prefix-arg instead of prefix-arg Kyle Hubert
2020-01-30  3:53 ` Kyle Hubert
2020-01-30 13:12   ` Noam Postavsky
2020-01-30 16:35     ` Kyle Hubert
2020-01-30 18:39       ` Eli Zaretskii
2020-01-31 14:29 ` bug#39353: [PATCH] Ediff fix for ediff-scroll-horizontally Kyle Hubert
2020-02-08 10:01   ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).