From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range error Date: Sun, 12 Apr 2020 13:33:37 +0300 Message-ID: <83blnxkn7i.fsf@gnu.org> References: <20200308090630.41238-1-stepnem@gmail.com> <87pndf17v5.fsf@gnus.org> <87zhcinbdl.fsf@gmail.com> <87d09ezudv.fsf@gnus.org> <83zhciby6s.fsf@gnu.org> <87imioo963.fsf@gmail.com> <875zeinoc0.fsf@gnus.org> <87wo6lc9n8.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="118634"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 39980@debbugs.gnu.org To: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 12 12:34:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jNZwJ-000Ujj-6W for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Apr 2020 12:34:11 +0200 Original-Received: from localhost ([::1]:60452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNZwH-0000F0-TP for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Apr 2020 06:34:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45540) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNZwA-0000Er-Ro for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 06:34:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jNZw9-0006Jv-O5 for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 06:34:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45869) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jNZw9-0006Jr-LH for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 06:34:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jNZw9-0002CV-HL for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 06:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Apr 2020 10:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39980 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39980-submit@debbugs.gnu.org id=B39980.15866876388449 (code B ref 39980); Sun, 12 Apr 2020 10:34:01 +0000 Original-Received: (at 39980) by debbugs.gnu.org; 12 Apr 2020 10:33:58 +0000 Original-Received: from localhost ([127.0.0.1]:57415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNZw5-0002CD-Tc for submit@debbugs.gnu.org; Sun, 12 Apr 2020 06:33:58 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNZw3-0002C0-BO for 39980@debbugs.gnu.org; Sun, 12 Apr 2020 06:33:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57153) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jNZvy-0006Fl-6E; Sun, 12 Apr 2020 06:33:50 -0400 Original-Received: from [176.228.60.248] (port=4024 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jNZvx-00029s-A0; Sun, 12 Apr 2020 06:33:49 -0400 In-Reply-To: <87wo6lc9n8.fsf@gmail.com> (message from =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= on Sun, 12 Apr 2020 11:53:47 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178231 Archived-At: > From: Štěpán Němec > Cc: 39980@debbugs.gnu.org, Lars Ingebrigtsen > Date: Sun, 12 Apr 2020 11:53:47 +0200 > > On Thu, 02 Apr 2020 13:01:35 +0200 > Lars Ingebrigtsen wrote: > > > Štěpán Němec writes: > > > >> Considering the opinions expressed here and in > >> https://lists.gnu.org/archive/html/emacs-devel/2020-03/msg00541.html I > >> have reverted to defun and autoload the function instead to prevent > >> having to load subr-x at runtime whenever gnus-sum is loaded, as it is > >> currently only used there by `gnus-summary-browse-url'. > >> > >> Revised patch attached. > > > > Looks good to me. > > This can go to emacs-27, right? `gnus-summary-browse-url' is new in > Emacs 27, it would seem a shame to ship it with this bug. OK for the change in gnus-summary-browse-url, but let's please leave out of emacs-27 changes that aren't necessarily needed to fix the original problem; cleanups are for master. On emacs-27, let's just fix the original problem locally. Thanks.