From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#40693: 28.0.50; json-encode-alist changes alist Date: Wed, 29 Apr 2020 15:21:45 +0300 Message-ID: <83blnazdly.fsf@gnu.org> References: <87a738jotd.fsf@tcd.ie> <87mu6utxd1.fsf@tcd.ie> <83r1w6ziql.fsf@gnu.org> <82572c3f-fb24-0b01-06ec-47067d9219ca@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="68072"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contovob@tcd.ie, darthandrus@gmail.com, 40693@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 29 14:23:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jTlk6-000Hap-RQ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Apr 2020 14:23:10 +0200 Original-Received: from localhost ([::1]:40872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTlk5-0007ez-Ss for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Apr 2020 08:23:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54916) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTljy-0007er-Nt for bug-gnu-emacs@gnu.org; Wed, 29 Apr 2020 08:23:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTljy-0005Tr-Bq for bug-gnu-emacs@gnu.org; Wed, 29 Apr 2020 08:23:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59331) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTljx-0005Tm-Vf for bug-gnu-emacs@gnu.org; Wed, 29 Apr 2020 08:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jTljx-0004PH-R6 for bug-gnu-emacs@gnu.org; Wed, 29 Apr 2020 08:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Apr 2020 12:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40693 X-GNU-PR-Package: emacs Original-Received: via spool by 40693-submit@debbugs.gnu.org id=B40693.158816293116860 (code B ref 40693); Wed, 29 Apr 2020 12:23:01 +0000 Original-Received: (at 40693) by debbugs.gnu.org; 29 Apr 2020 12:22:11 +0000 Original-Received: from localhost ([127.0.0.1]:42639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTlj8-0004Ns-Vi for submit@debbugs.gnu.org; Wed, 29 Apr 2020 08:22:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTlj7-0004Nf-A6 for 40693@debbugs.gnu.org; Wed, 29 Apr 2020 08:22:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53739) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTlj1-0005C9-Ml; Wed, 29 Apr 2020 08:22:03 -0400 Original-Received: from [176.228.60.248] (port=3808 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jTlj1-0002iN-3T; Wed, 29 Apr 2020 08:22:03 -0400 In-Reply-To: <82572c3f-fb24-0b01-06ec-47067d9219ca@yandex.ru> (message from Dmitry Gutov on Wed, 29 Apr 2020 15:08:57 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179305 Archived-At: > Cc: darthandrus@gmail.com, 40693@debbugs.gnu.org > From: Dmitry Gutov > Date: Wed, 29 Apr 2020 15:08:57 +0300 > > > No one tried to come up with arguments why this has to be in emacs-27. > > Let me try: > > It fixes a bug, one which could be annoying to investigate, the fix is > small and localized to the case when json-encoding-object-sort-predicate > is non-nil (so pretty safe). It also makes the function slower. Which may be an important issue for JSON processing. Callers that don't care about the original list will be "punished" regardless. How about adding an optional argument instead, by default off, to request this behavior? then callers who care about the original alist could request a non-destructive operation, and others won't suffer any slowdown. > It's not a regression from Emacs 26, though. Right.