From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 41520@debbugs.gnu.org, stefan@marxist.se, pipcet@gmail.com
Subject: bug#41520: 28.0.50; Crash in character.h due to assertion error
Date: Sun, 27 Sep 2020 18:15:53 +0300 [thread overview]
Message-ID: <83blhrntcm.fsf@gnu.org> (raw)
In-Reply-To: <87wo0f1e3e.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 27 Sep 2020 16:36:21 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Pip Cet <pipcet@gmail.com>, 41520@debbugs.gnu.org, stefan@marxist.se
> Date: Sun, 27 Sep 2020 16:36:21 +0200
>
> > I'm okay with those additional changes, but let's install them on
> > master, as they are a cleanup, not a bug.
>
> Pip's patch from May no longer applies cleanly, so I've respun it for
> the trunk now.
>
> Does this still look OK?
Almost. I'd rather skip this part:
> @@ -882,8 +881,7 @@ back_comment (ptrdiff_t from, ptrdiff_t from_byte, ptrdiff_t stop,
> if (open_paren_in_column_0_is_defun_start
> && NILP (Vcomment_use_syntax_ppss)
> && (from == stop
> - || (temp_byte = dec_bytepos (from_byte),
> - FETCH_CHAR (temp_byte) == '\n')))
> + || (FETCH_BYTE (from_byte - 1) == '\n')))
It might be that I'm being paranoid here, but I don't like calling
FETCH_BYTE when we are potentially in the middle of a multibyte
sequence or near the gap.
The rest should be fine, thanks.
next prev parent reply other threads:[~2020-09-27 15:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 7:05 bug#41520: 28.0.50; Crash in character.h due to assertion error Stefan Kangas
2020-05-25 7:28 ` Pip Cet
2020-05-25 7:41 ` Pip Cet
2020-05-25 14:18 ` Eli Zaretskii
2020-05-25 14:30 ` Pip Cet
2020-05-25 15:07 ` Eli Zaretskii
2020-05-25 15:16 ` Pip Cet
2020-05-25 16:09 ` Eli Zaretskii
2020-05-25 17:54 ` Pip Cet
2020-05-25 19:30 ` Eli Zaretskii
2020-05-25 20:39 ` Pip Cet
2020-05-26 16:17 ` Eli Zaretskii
2020-09-27 14:36 ` Lars Ingebrigtsen
2020-09-27 15:15 ` Eli Zaretskii [this message]
2020-09-27 15:42 ` Lars Ingebrigtsen
2020-09-27 16:00 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83blhrntcm.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=41520@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=pipcet@gmail.com \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).