From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#46243: [External] : Re: bug#46243: 26.3; If invoke menu item that reads a char, get keystrokes echo Date: Thu, 04 Feb 2021 19:37:24 +0200 Message-ID: <83blczray3.fsf@gnu.org> References: <83r1lz60so.fsf@gnu.org> <83a6sm5rlr.fsf@gnu.org> <83pn1h401u.fsf@gnu.org> <83k0rp3wew.fsf@gnu.org> <83lfc3rfvp.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19782"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46243-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 04 19:37:07 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7jV5-00051U-IW for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Feb 2021 19:37:07 +0100 Original-Received: from localhost ([::1]:48590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7jV3-0003Ua-Tg for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Feb 2021 13:37:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54568) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7iZv-0002MB-0N for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2021 12:38:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58860) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l7iZu-0005JL-Bf for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2021 12:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l7iZu-0003pd-9h for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2021 12:38:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Feb 2021 17:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 46243 X-GNU-PR-Package: emacs Mail-Followup-To: 46243@debbugs.gnu.org, eliz@gnu.org, drew.adams@oracle.com Original-Received: via spool by 46243-done@debbugs.gnu.org id=D46243.161246025314685 (code D ref 46243); Thu, 04 Feb 2021 17:38:02 +0000 Original-Received: (at 46243-done) by debbugs.gnu.org; 4 Feb 2021 17:37:33 +0000 Original-Received: from localhost ([127.0.0.1]:42172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7iZR-0003on-7R for submit@debbugs.gnu.org; Thu, 04 Feb 2021 12:37:33 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7iZO-0003oY-Tb for 46243-done@debbugs.gnu.org; Thu, 04 Feb 2021 12:37:32 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41936) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7iZJ-0004xJ-IV; Thu, 04 Feb 2021 12:37:25 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3509 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l7iZH-00032K-2p; Thu, 04 Feb 2021 12:37:23 -0500 In-Reply-To: (message from Stefan Monnier on Thu, 04 Feb 2021 11:50:14 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199318 Archived-At: > From: Stefan Monnier > Cc: drew.adams@oracle.com, 46243@debbugs.gnu.org > Date: Thu, 04 Feb 2021 11:50:14 -0500 > > > So I propose the much simpler patch below. It may look like a kludgey > > band-aid at first sight, but OTOH consider this: > > Looks OK to me. It's fairly unusual to want echo-keystrokes working > when there's a prompt in any case. The only case I can think of right > now is for `C-h k` and `C-h c` (but these use `read-key-sequence` so > I think they won't be affected). Thanks. I verified that "C-h k" works, including when invoked via the menus, and installed this on the master branch. With that, I'm closing this bug.