From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#43725: 28.0.50; Include feature/native-comp into master Date: Fri, 19 Feb 2021 10:14:59 +0200 Message-ID: <83blcg4gos.fsf@gnu.org> References: <87wny8xwcc.fsf@gnus.org> <83im9sqk1b.fsf@gnu.org> <83v9drp8va.fsf@gnu.org> <831rdjd95w.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28613"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, monnier@iro.umontreal.ca, 43725@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 19 09:15:20 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lD0wa-0007LK-JA for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Feb 2021 09:15:20 +0100 Original-Received: from localhost ([::1]:48892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lD0wZ-00013s-KM for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Feb 2021 03:15:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD0wM-00013T-4m for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 03:15:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37124) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lD0wI-0001HF-Jt for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 03:15:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lD0wI-0008DX-E3 for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 03:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Feb 2021 08:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43725 X-GNU-PR-Package: emacs Original-Received: via spool by 43725-submit@debbugs.gnu.org id=B43725.161372249431560 (code B ref 43725); Fri, 19 Feb 2021 08:15:02 +0000 Original-Received: (at 43725) by debbugs.gnu.org; 19 Feb 2021 08:14:54 +0000 Original-Received: from localhost ([127.0.0.1]:48670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lD0wA-0008Cy-3w for submit@debbugs.gnu.org; Fri, 19 Feb 2021 03:14:54 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lD0w8-0008Cl-Gq for 43725@debbugs.gnu.org; Fri, 19 Feb 2021 03:14:52 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58604) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lD0w0-000195-ML; Fri, 19 Feb 2021 03:14:45 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2125 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lD0vz-0003k4-L7; Fri, 19 Feb 2021 03:14:44 -0500 In-Reply-To: (message from Andrea Corallo on Thu, 18 Feb 2021 21:56:47 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200309 Archived-At: > From: Andrea Corallo > Cc: larsi@gnus.org, monnier@iro.umontreal.ca, 43725@debbugs.gnu.org > Date: Thu, 18 Feb 2021 21:56:47 +0000 > > > +#ifdef WINDOWSNT > > + /* We may need to load libgccjit when dumping before term/w32-win.el > > + defines `dynamic-library-alist`. This will fail if that variable > > + is empty, so add libgccjit-0.dll to it. */ > > + if (will_dump_p ()) > > + Vdynamic_library_alist = list1 (list2 (Qgccjit, > > + build_string ("libgccjit-0.dll"))); > > > > Is there a more elegant way of resolving this difficulty? > > I've no precise idea. I guess `dynamic-library-alist` should be > initialized before any compilation can be triggered, not sure how easy > is that, is also something I can't test and as a consequence develop. If libgccjit DLL must be loaded early on, perhaps it shouldn't use the Vdynamic_library_alist machinery at all, but have its own loading code? Anyway, we can delay this cleanup until the branch is merged with master, that's why I asked for FIXME. > > This lacks the ENCODE_FILE part: > > > > + char *fname = SSDATA (concat2 (Vinvocation_directory, > > + XCAR (comp_u->file))); > > + FILE *file; > > + if ((file = fopen (fname, "r"))) > > > > And why are you using fopen instead of emacs_fopen? > > 2110a3faf7 fix both suggestons. Thanks. For the future: it is important to go through existing Emacs APIs that accept file names, because on Windows we must convert UTF-8 encoded file names to UTF-16, so as to provide full support for non-ASCII file names and directory names. This conversion happens in w32.c, which defines wrappers for functions like fopen, so directly calling those C APIs is generally a bug waiting to happen.