From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#47012: xref copies keymap properties to minibuffer Date: Fri, 02 Apr 2021 09:08:40 +0300 Message-ID: <83blaxfcbb.fsf@gnu.org> References: <87czw9tnu9.fsf@mail.linkov.net> <3aad442a-7319-5db5-2fc6-560bb032c34d@yandex.ru> <87a6r9v24b.fsf@mail.linkov.net> <87sg4kb839.fsf@mail.linkov.net> <871rc3bls6.fsf@mail.linkov.net> <871rc2ly7x.fsf@mail.linkov.net> <4228b128-039c-2bcd-002c-5ac830d7a4d3@yandex.ru> <87pmzgtr80.fsf@mail.linkov.net> <186b46fa-3716-a76d-db85-09638d7805c7@yandex.ru> <87v99745jj.fsf@mail.linkov.net> <87zgyiv03f.fsf@mail.linkov.net> <4d3edf81-97d8-4e0e-51c0-7b2d71b57889@yandex.ru> <87o8exsv1p.fsf@mail.linkov.net> <83o8exg6za.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17626"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47012@debbugs.gnu.org, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 02 08:10:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lSD0T-0004VO-Nd for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Apr 2021 08:10:09 +0200 Original-Received: from localhost ([::1]:32794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lSD0S-0005Cr-BT for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Apr 2021 02:10:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45110) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lSD0M-0005Cc-Ej for bug-gnu-emacs@gnu.org; Fri, 02 Apr 2021 02:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47426) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lSD0M-0007cZ-7N for bug-gnu-emacs@gnu.org; Fri, 02 Apr 2021 02:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lSD0L-0008JR-Uv for bug-gnu-emacs@gnu.org; Fri, 02 Apr 2021 02:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Apr 2021 06:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47012 X-GNU-PR-Package: emacs Original-Received: via spool by 47012-submit@debbugs.gnu.org id=B47012.161734374531882 (code B ref 47012); Fri, 02 Apr 2021 06:10:01 +0000 Original-Received: (at 47012) by debbugs.gnu.org; 2 Apr 2021 06:09:05 +0000 Original-Received: from localhost ([127.0.0.1]:58972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSCzQ-0008IA-Ps for submit@debbugs.gnu.org; Fri, 02 Apr 2021 02:09:05 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSCzQ-0008Hh-5I for 47012@debbugs.gnu.org; Fri, 02 Apr 2021 02:09:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43087) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lSCzJ-0006wS-Cx; Fri, 02 Apr 2021 02:08:57 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1649 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lSCzH-0001VK-V2; Fri, 02 Apr 2021 02:08:56 -0400 In-Reply-To: (message from Dmitry Gutov on Fri, 2 Apr 2021 00:28:25 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203459 Archived-At: > Cc: 47012@debbugs.gnu.org > From: Dmitry Gutov > Date: Fri, 2 Apr 2021 00:28:25 +0300 > > On 01.04.2021 22:06, Eli Zaretskii wrote: > > Please don't make this change, it makes the matches very hard to find. > > Personally, I don't understand how you can use such a background > > color, unless you also customize the default background. > > Did you like any of the options I suggested? I didn't try them, and re-reading the thread now I don't think I understand which options are you referring to here. There was one suggestion, to add the bold attribute to the existing face, which you later retracted because that face is already bold, but I see no other concrete suggestions for changes in that face. What am I missing? Could you please list those options for which you'd like my opinion? > > In general, when discussing faces used by some feature (in this case > > Xref and project.el), please don't change the defaults of unrelated > > faces, let alone more general ones. > > I agree it should be a separate change/discussion. > > Should we continue that in a new bug report or on emacs-devel? If it's an important issue, probably the latter. If it's just a tool to fix some other face, I'd prefer not to change Occur faces at all, and instead find an independent way of doing TRT with Xref and/or project.el faces. There's nothing wrong with the default Occur faces, and I saw no complaints about it.