From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#47712: 27.1; Provide `string-display-width` function, which takes properties into account, `substring-width` Date: Mon, 12 Apr 2021 17:15:17 +0300 Message-ID: <83blaj37yi.fsf@gnu.org> References: <642c8a37-31c7-2723-12af-06cd7f120c2f@daniel-mendler.de> <83r1jg2q72.fsf@gnu.org> <83lf9n3d7x.fsf@gnu.org> <1c8f7066-3da2-d960-11e7-a42f567432bd@daniel-mendler.de> <83im4r3agk.fsf@gnu.org> <83czuz39jw.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34042"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47712@debbugs.gnu.org To: Daniel Mendler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 12 16:18:40 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVxOi-0008kQ-DK for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Apr 2021 16:18:40 +0200 Original-Received: from localhost ([::1]:60980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVxOh-0001XV-E8 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Apr 2021 10:18:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVxMA-0008Co-1e for bug-gnu-emacs@gnu.org; Mon, 12 Apr 2021 10:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46095) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lVxM9-0005Rl-Qm for bug-gnu-emacs@gnu.org; Mon, 12 Apr 2021 10:16:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lVxM9-0000Cd-ML for bug-gnu-emacs@gnu.org; Mon, 12 Apr 2021 10:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Apr 2021 14:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47712 X-GNU-PR-Package: emacs Original-Received: via spool by 47712-submit@debbugs.gnu.org id=B47712.1618236943752 (code B ref 47712); Mon, 12 Apr 2021 14:16:01 +0000 Original-Received: (at 47712) by debbugs.gnu.org; 12 Apr 2021 14:15:43 +0000 Original-Received: from localhost ([127.0.0.1]:57641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVxLr-0000C4-Cr for submit@debbugs.gnu.org; Mon, 12 Apr 2021 10:15:43 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVxLp-0000Bp-7i for 47712@debbugs.gnu.org; Mon, 12 Apr 2021 10:15:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55442) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVxLj-0005Ay-Bi; Mon, 12 Apr 2021 10:15:35 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2340 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lVxLi-0002p0-Ik; Mon, 12 Apr 2021 10:15:35 -0400 In-Reply-To: (message from Daniel Mendler on Mon, 12 Apr 2021 16:05:41 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203905 Archived-At: > Cc: 47712@debbugs.gnu.org > From: Daniel Mendler > Date: Mon, 12 Apr 2021 16:05:41 +0200 > > I gave it a quick test. See the function `string-pixel-width` below. It > seems that it does not take 'invisible and 'display into account. I > probably have to change something to ensure that the properties are not > ignored. If these properties are ignored, they will also be ignored on display. > But for we can still look at the micro benchmark. The `string-width` > function is 200 times faster than the `string-pixel-width` function. And if you reuse the same temp buffer? > I am still not happy with replacing `string-width` with something so > much slower. With 0.5 millisecond per call, I don't see a problem. And I expect that to go down if the buffer is reused. > (defmacro bench (&rest body) > (let ((start (make-symbol "t"))) > `(let (,start) > (setq ,start (current-time)) > ,@body > (float-time (time-since ,start))))) Please use benchmark-run, as that also tells us about GC during the run, and important aspect.