From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48137: 27.2; `package-install-file' fails when loading a package file with DOS line endings Date: Thu, 06 May 2021 18:26:48 +0300 Message-ID: <83bl9nevd3.fsf@gnu.org> References: <834kfmabvs.fsf@gnu.org> <83tunj651i.fsf@gnu.org> <83lf8u68bu.fsf@gnu.org> <83mtta4gtf.fsf@gnu.org> <83fsz24f2x.fsf@gnu.org> <83v97x2xum.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28208"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ioannis.kappas@gmail.com, 48137@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 06 17:28:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lefvB-00077j-Ir for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 17:28:13 +0200 Original-Received: from localhost ([::1]:55160 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lefvA-0006sh-Kr for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 11:28:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lefv0-0006pS-OE for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 11:28:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54795) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lefv0-0003iW-Gb for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 11:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lefv0-0001tp-Df for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 11:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 May 2021 15:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48137 X-GNU-PR-Package: emacs Original-Received: via spool by 48137-submit@debbugs.gnu.org id=B48137.16203148267275 (code B ref 48137); Thu, 06 May 2021 15:28:02 +0000 Original-Received: (at 48137) by debbugs.gnu.org; 6 May 2021 15:27:06 +0000 Original-Received: from localhost ([127.0.0.1]:38102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lefu6-0001tH-5f for submit@debbugs.gnu.org; Thu, 06 May 2021 11:27:06 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lefu4-0001sY-76 for 48137@debbugs.gnu.org; Thu, 06 May 2021 11:27:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44602) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lefty-0003FN-IN; Thu, 06 May 2021 11:26:58 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2284 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.86_2) (envelope-from ) id 1lefty-0001BZ-4r; Thu, 06 May 2021 11:26:58 -0400 In-Reply-To: (message from Stefan Monnier on Thu, 06 May 2021 09:27:38 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205848 Archived-At: > From: Stefan Monnier > Cc: Eli Zaretskii , 48137@debbugs.gnu.org > Date: Thu, 06 May 2021 09:27:38 -0400 > > That's not sufficient, because if we don't decode the file before we > call `package-buffer-info` (from `package-install-from-buffer`), then > the -pkg.el file will have incorrect content (e.g. the non-ASCII > chars in the description of the package, will be later incorrectly > displayed in `list-packages`). So you are saying the description of the package needs to be decoded before using it for list-packages? That'd be okay; all I care about is that the decoded stuff does NOT replace the original raw bytes, but instead is used only where decoding is needed. IOW, decoding should either be done on substrings of the original file, and the result stored in strings, or the decoded stuff should be placed in a separate scratch buffer, which will be used only where decoding is really needed.