From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48669: Inconsistent overlay placement between minibuffer-message and set-minibuffer-message Date: Mon, 07 Jun 2021 15:21:04 +0300 Message-ID: <83bl8hhnm7.fsf@gnu.org> References: <87k0n8kl1h.fsf@mail.linkov.net> <83r1hfilfg.fsf@gnu.org> <875yyqlnml.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28746"; mail-complaints-to="usenet@ciao.gmane.io" Cc: joca.bt@gmail.com, 48669@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 08 02:06:41 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqPGR-0007H9-D6 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Jun 2021 02:06:39 +0200 Original-Received: from localhost ([::1]:39758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqPGQ-0000iz-9o for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Jun 2021 20:06:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqPFs-0000dH-6B for bug-gnu-emacs@gnu.org; Mon, 07 Jun 2021 20:06:10 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45349) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqPFr-0002Kw-Ff for bug-gnu-emacs@gnu.org; Mon, 07 Jun 2021 20:06:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lqPFr-0007QW-7X for bug-gnu-emacs@gnu.org; Mon, 07 Jun 2021 20:06:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Jun 2021 00:06:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48669 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48669-submit@debbugs.gnu.org id=B48669.162311073828482 (code B ref 48669); Tue, 08 Jun 2021 00:06:03 +0000 Original-Received: (at 48669) by debbugs.gnu.org; 8 Jun 2021 00:05:38 +0000 Original-Received: from localhost ([127.0.0.1]:56888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqPFS-0007PI-6v for submit@debbugs.gnu.org; Mon, 07 Jun 2021 20:05:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqPFR-0007P0-5E for 48669@debbugs.gnu.org; Mon, 07 Jun 2021 20:05:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39454) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqPFL-00018D-IN; Mon, 07 Jun 2021 20:05:31 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4985 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqEFf-0001b7-1Y; Mon, 07 Jun 2021 08:21:07 -0400 In-Reply-To: <875yyqlnml.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 06 Jun 2021 23:54:58 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208202 Archived-At: > From: Juri Linkov > Cc: joca.bt@gmail.com, 48669@debbugs.gnu.org > Date: Sun, 06 Jun 2021 23:54:58 +0300 > > >> - (let ((ol (make-overlay (point-max) (point-max) nil t t)) > >> + (let* ((ovpos (minibuffer--message-overlay-pos)) > >> + (ol (make-overlay ovpos ovpos nil t t)) > > > > Doesn't this rely too much on the internal details of > > minibuffer--message-overlay-pos? At least, without any comments, this > > call looks like a riddle that isn't easy to unlock. > > If minibuffer--message-overlay-pos serves its purpose for > set-minibuffer-message, it seems suitable for > minibuffer-message as well. So you object to adding a comment there which would explain what that call does? > >> - (put-text-property 0 1 'cursor t message)) > >> + (put-text-property 0 1 'cursor 1 message)) > > > > Why this change? > > Only to make minibuffer-message the identical copy of > set-minibuffer-message. I'd say make it the other way around. Handling the 'cursor' property with a numeric value is more expensive and tricky than if the value is t, and in this case the effect is exactly the same.