From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50660: 28.0.50; Text artifacting when the cursor moves over text under mouse face that originally displayed a box Date: Thu, 14 Oct 2021 18:51:04 +0300 Message-ID: <83bl3rli53.fsf@gnu.org> References: <87czp6ysw7.fsf.ref@yahoo.com> <83sfxyxeer.fsf@gnu.org> <87h7ee1252.fsf@yahoo.com> <83pmt2xcox.fsf@gnu.org> <87lf3myhlb.fsf@yahoo.com> <87a6jzvnpq.fsf@yahoo.com> <83o88fom1k.fsf@gnu.org> <871r5bvex8.fsf@yahoo.com> <83v92mkzft.fsf@gnu.org> <87k0j0rwo3.fsf@yahoo.com> <838rzbddfa.fsf@gnu.org> <878rzbd1w5.fsf@yahoo.com> <83wnmgkmok.fsf@gnu.org> <878ryvnain.fsf@yahoo.com> <83mtnbltyp.fsf@gnu.org> <87mtnblt35.fsf@yahoo.com> <83ilxzlsck.fsf@gnu.org> <877defls2w.fsf@yahoo.com> <83fst3lrwr.fsf@gnu.org> <87o87rkczt.fsf@yahoo.com> <83czo7lqrl.fsf@gnu.org> <87h7djkayk.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33430"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 50660@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 14 18:14:20 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mb3N5-0008XC-Vd for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Oct 2021 18:14:19 +0200 Original-Received: from localhost ([::1]:54534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mb3N4-0004Kv-3K for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Oct 2021 12:14:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mb31W-0007P3-KH for bug-gnu-emacs@gnu.org; Thu, 14 Oct 2021 11:52:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53532) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mb31W-00088I-9j for bug-gnu-emacs@gnu.org; Thu, 14 Oct 2021 11:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mb31W-0004Dr-5X for bug-gnu-emacs@gnu.org; Thu, 14 Oct 2021 11:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Oct 2021 15:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50660 X-GNU-PR-Package: emacs Original-Received: via spool by 50660-submit@debbugs.gnu.org id=B50660.163422667516175 (code B ref 50660); Thu, 14 Oct 2021 15:52:02 +0000 Original-Received: (at 50660) by debbugs.gnu.org; 14 Oct 2021 15:51:15 +0000 Original-Received: from localhost ([127.0.0.1]:36845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mb30l-0004Cn-FF for submit@debbugs.gnu.org; Thu, 14 Oct 2021 11:51:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mb30i-0004Cb-9t for 50660@debbugs.gnu.org; Thu, 14 Oct 2021 11:51:13 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52340) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mb30c-0007Oj-Vb; Thu, 14 Oct 2021 11:51:06 -0400 Original-Received: from [87.69.77.57] (port=1916 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mb30c-0003kt-JB; Thu, 14 Oct 2021 11:51:06 -0400 In-Reply-To: <87h7djkayk.fsf@yahoo.com> (message from Po Lu on Thu, 14 Oct 2021 21:11:31 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217229 Archived-At: > From: Po Lu > Cc: larsi@gnus.org, 50660@debbugs.gnu.org > Date: Thu, 14 Oct 2021 21:11:31 +0800 > > Thanks for the clarifications. One last question though, if I make the > change to setting the face in draw_glyphs, it would be OK to remove > x_set_mouse_face_gc, because the face is already set correctly by > draw_glyphs, and no other adjustments to the GC or glyph string will be > required, right? No, I think it's wrong to set the face GC in xdisp.c, because the GC is fundamentally terminal-specific, so it belongs to xterm/w32term etc. I'm not even sure xdisp.c knows the exact type of GC, which differs according to the platform. The logic of selecting the face should indeed be removed from x_set_mouse_face_gc, but the calls to XChangeGC etc. should remain there.