From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38181: Actual height of mode-line not taken into account Date: Fri, 15 Oct 2021 10:54:29 +0300 Message-ID: <83bl3qk9je.fsf@gnu.org> References: <87eeyd3ul0.fsf@bernoul.li> <2a0bf8c7-69df-0532-c6d8-5315ee9fee28@gmx.at> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33697"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 38181@debbugs.gnu.org To: Carlos Pita Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 15 10:52:38 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mbIxC-0008Yb-29 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Oct 2021 10:52:38 +0200 Original-Received: from localhost ([::1]:38502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mbIxA-0006ck-SK for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Oct 2021 04:52:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48932) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbI3S-0004ZN-1z for bug-gnu-emacs@gnu.org; Fri, 15 Oct 2021 03:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54679) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mbI3R-0000Hc-Nr for bug-gnu-emacs@gnu.org; Fri, 15 Oct 2021 03:55:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mbI3R-0000uD-Lb for bug-gnu-emacs@gnu.org; Fri, 15 Oct 2021 03:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Oct 2021 07:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38181 X-GNU-PR-Package: emacs Original-Received: via spool by 38181-submit@debbugs.gnu.org id=B38181.16342844793449 (code B ref 38181); Fri, 15 Oct 2021 07:55:01 +0000 Original-Received: (at 38181) by debbugs.gnu.org; 15 Oct 2021 07:54:39 +0000 Original-Received: from localhost ([127.0.0.1]:37992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mbI35-0000tY-Af for submit@debbugs.gnu.org; Fri, 15 Oct 2021 03:54:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mbI33-0000tK-3V for 38181@debbugs.gnu.org; Fri, 15 Oct 2021 03:54:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51844) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mbI2x-0008Jk-65; Fri, 15 Oct 2021 03:54:31 -0400 Original-Received: from [87.69.77.57] (port=1952 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbI2v-0002Fe-Ur; Fri, 15 Oct 2021 03:54:31 -0400 In-Reply-To: (message from Carlos Pita on Fri, 15 Oct 2021 04:26:51 -0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217294 Archived-At: > From: Carlos Pita > Date: Fri, 15 Oct 2021 04:26:51 -0300 > Cc: 38181@debbugs.gnu.org > > > If the underlying scenario is that you first fit a window to its buffer > > and then enlarge the height of that window's mode-line, there's not much > > we can do here currently. It's like fitting a window to its buffer and > > then adding a header line or a horizontal scroll bar to that window. > > I can't say I understand the details discussed here but I'm not quite > sure your description fits the situation. > > The workaround since this bug was first reported has been: immediately > before fit-window-to-buffer execute an advice that forces a redisplay, > then deactivate the advice. > > But the problem I'm seeing now is that the first time > org-set-tags-command is executed its popup is correctly sized (with > said workaround in place, of course), but further executions show a > popup with the wrong geometry that trims part of the text off. If I > remove the "just once" clause in the workaround, so that the redisplay > is forced after each fit-window-to-buffer execution, then the layout > is correct every time. It goes without saying that > org-set-tags-command is ultimately triggering the execution of > fit-window-to-buffer, but that stuff you probably know much better > than me. Thing is, there was no enlargement of the modeline > in-between, as far as I can understand and see nothing changed in this > regard between the first and the second execution of > org-set-tags-command. Can you show the recipe for the problem, starting from "emacs -Q"? It sounds from what you say that the problem is not with the mode line, but with something else. If that is true, please submit a new bug report. This bug is about redisplaying the mode line when something changes in mode-line-format that affects the height of the mode line. If there are other problems with fit-window-to-buffer, they should be discussed separately.