From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50752: 28.0.50; easy-menu-define lowers the menu-bar key Date: Wed, 20 Oct 2021 15:59:21 +0300 Message-ID: <83bl3jc0nq.fsf@gnu.org> References: <87bl4jvudm.fsf@gnus.org> <837dehp248.fsf@gnu.org> <87czo96shw.fsf@gnus.org> <87wnmh5bes.fsf@gnus.org> <87wnmh3p9k.fsf@gnus.org> <83sfwxck9r.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22258"; mail-complaints-to="usenet@ciao.gmane.io" Cc: shuguang79@qq.com, larsi@gnus.org, 50752@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 20 15:01:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mdBDa-0005YW-Nz for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Oct 2021 15:01:18 +0200 Original-Received: from localhost ([::1]:51756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mdBDZ-0006nj-JT for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Oct 2021 09:01:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdBCN-0006mX-3o for bug-gnu-emacs@gnu.org; Wed, 20 Oct 2021 09:00:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41455) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mdBCM-0000Sz-RK for bug-gnu-emacs@gnu.org; Wed, 20 Oct 2021 09:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mdBCM-0008U5-Qq for bug-gnu-emacs@gnu.org; Wed, 20 Oct 2021 09:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Oct 2021 13:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50752 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50752-submit@debbugs.gnu.org id=B50752.163473476332538 (code B ref 50752); Wed, 20 Oct 2021 13:00:02 +0000 Original-Received: (at 50752) by debbugs.gnu.org; 20 Oct 2021 12:59:23 +0000 Original-Received: from localhost ([127.0.0.1]:53001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdBBj-0008Sk-8z for submit@debbugs.gnu.org; Wed, 20 Oct 2021 08:59:23 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdBBg-0008SW-KJ for 50752@debbugs.gnu.org; Wed, 20 Oct 2021 08:59:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38146) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mdBBX-0008CO-9R; Wed, 20 Oct 2021 08:59:11 -0400 Original-Received: from [87.69.77.57] (port=4418 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdBBW-0000gQ-Hi; Wed, 20 Oct 2021 08:59:10 -0400 In-Reply-To: (message from Stefan Kangas on Tue, 19 Oct 2021 14:54:59 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217664 Archived-At: > From: Stefan Kangas > Date: Tue, 19 Oct 2021 14:54:59 -0700 > Cc: larsi@gnus.org, shuguang79@qq.com, 50752@debbugs.gnu.org > > +/* Char table for the backwards-compatibility part in Flookup_key. */ > +Lisp_Object unicode_case_table; Should be static, I guess. > + /* Initialize the unicode case table, if it wasn't already. */ > + if (NILP (unicode_case_table)) > + unicode_case_table = uniprop_table (intern ("lowercase")); This is okay, but the call to staticpro should be immediately after you call uniprop_table, so that you protect the value of the table as it was created. It won't work to staticpro it in syms_of_keymap, which runs in temacs at build time. > + if (!STRING_MULTIBYTE (key_item)) > + { > + new_item = Fdowncase (key_item); > + } Style: a single statement in a block doesn't need braces. And I guess the above assumes we resolve the issue with Turkish locales when unibyte strings are downcased? Otherwise, LGTM (but I didn't try applying and running the code).