From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#52888: Date: Thu, 13 Jan 2022 20:13:16 +0200 Message-ID: <83bl0f33nn.fsf@gnu.org> References: <87zgoi8xve.fsf@melete.silentflame.com> <83czkv37xl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3129"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52888@debbugs.gnu.org To: =?UTF-8?Q?Andr=C3=A9?= Silva Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 13 19:22:07 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n84jf-0000fU-0g for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jan 2022 19:22:07 +0100 Original-Received: from localhost ([::1]:43186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n84je-000476-16 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jan 2022 13:22:06 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46530) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n84bq-0003Q1-N5 for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 13:14:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41651) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n84bq-00028e-4k for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 13:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n84bq-0003sb-1A for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 13:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jan 2022 18:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52888 X-GNU-PR-Package: emacs Original-Received: via spool by 52888-submit@debbugs.gnu.org id=B52888.164209760814854 (code B ref 52888); Thu, 13 Jan 2022 18:14:01 +0000 Original-Received: (at 52888) by debbugs.gnu.org; 13 Jan 2022 18:13:28 +0000 Original-Received: from localhost ([127.0.0.1]:34554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n84bI-0003rW-9c for submit@debbugs.gnu.org; Thu, 13 Jan 2022 13:13:28 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n84bF-0003rE-9d for 52888@debbugs.gnu.org; Thu, 13 Jan 2022 13:13:27 -0500 Original-Received: from [2001:470:142:3::e] (port=50144 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n84b8-00024N-T9; Thu, 13 Jan 2022 13:13:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=lG3U0Kb+em5sDfgtVr4p82VIGSSbkcGOVZ7hsulgBNI=; b=jHuunV8boXEV31vyi200 CSwUt43I2STsKD7q5KLXyTQOT/xAyqv3+8cexrjP5oO/xtEhjwec46/dKs4krvrN6Afc5zD7f6dhX ylJqBp1eHefTK1G7wkpTDvWee25wLf/czdc+otQ8MUYjL8cMFsz9cHU2HJEofZt9pyrWiqyZe7PHw +ft6zNhC0DDYEtuqll2aWdHqEm70RKEenJwBbUbVOH6sWNG57vfNbj5JYbAild9njVG12kPo4ilcX qybT9exFJhliLzm1snkmVI4CDjTKU8Cm5DjdTVdJ4ow2d8sDPdpzxldBP1R+INS2PGF1qxsUGle63 X6Xqf37cwPR58Q==; Original-Received: from [87.69.77.57] (port=2640 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n84b8-0007Zj-T4; Thu, 13 Jan 2022 13:13:19 -0500 In-Reply-To: (message from =?UTF-8?Q?Andr=C3=A9?= Silva on Thu, 13 Jan 2022 17:04:34 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224126 Archived-At: [Please use Reply All to keep the bug tracker on the CC list.] > From: André Silva > Date: Thu, 13 Jan 2022 17:04:34 +0000 > > I don't, and I'm using doom-emacs so creating a minimal test case would take some effort (and probably > also depends on the font I'm using). That said if you look at the fix you committed if `FIXNUMP (AREF (entity, > prop))` returns false then the rest of the expression will get short-circuited (since it's an &&) and we will > negate the result therefore entering the if statement. I believe this is contrary to what we want. No, I think that's exactly what we want: fonts for which the attribute is not a number should be ignored. Your change will cause Emacs to use them, right?