From: Eli Zaretskii <eliz@gnu.org>
To: Mauro Aranda <maurooaranda@gmail.com>
Cc: luangruo@yahoo.com, 13476@debbugs.gnu.org, stephen.berman@gmx.net
Subject: bug#13476: 24.3.50; Reverting scroll-bar face customization has no effect
Date: Mon, 28 Feb 2022 16:49:40 +0200 [thread overview]
Message-ID: <83bkyrm4fv.fsf@gnu.org> (raw)
In-Reply-To: <621cd660.1c69fb81.2604f.da8d@mx.google.com> (message from Mauro Aranda on Mon, 28 Feb 2022 11:04:13 -0300)
> From: Mauro Aranda <maurooaranda@gmail.com>
> Cc: luangruo@yahoo.com, 13476@debbugs.gnu.org, stephen.berman@gmx.net
> Date: Mon, 28 Feb 2022 11:04:13 -0300
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Mauro Aranda <maurooaranda@gmail.com>
> >> Cc: eliz@gnu.org, 13476@debbugs.gnu.org, stephen.berman@gmx.net
> >> Date: Mon, 28 Feb 2022 09:59:15 -0300
> >>
> >> > --- a/lisp/faces.el
> >> > +++ b/lisp/faces.el
> >> > @@ -1743,7 +1743,14 @@ The following sources are applied in this order:
> >> > (and tail (face-spec-set-2 face frame
> >> > (list :extend (cadr tail))))))
> >> > (setq face-attrs (face-spec-choose (get face 'face-override-spec) frame))
> >> > - (face-spec-set-2 face frame face-attrs)))
> >> > + (face-spec-set-2 face frame face-attrs)
> >> > + (when (and (fboundp 'set-frame-parameter) ; This isn't available
> >> > + ; during loadup.
> >> > + (eq face 'scroll-bar))
> >> > + ;; Set the `scroll-bar-foreground' and `scroll-bar-background'
> >> > + ;; frame parameters. (bug#13476)
> >> > + (set-frame-parameter frame 'scroll-bar-foreground (face-foreground face))
> >> > + (set-frame-parameter frame 'scroll-bar-background (face-background face)))))
> >
> > Why do we need this special treatment of the scroll-bar face?
>
> I haven't read the code yet so I can't really answer to your question. What
> I know is what I said on
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=13476#8
>
> Customizing and then resetting to the standard scroll-bar face failed
> because the 'scroll-bar-foreground parameter wasn't updated after
> resetting the attributes via face-spec-reset-face.
I don't understand why we need to set the frame parameter when the
customize the face to begin with, I guess.
next prev parent reply other threads:[~2022-02-28 14:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 11:12 bug#13476: 24.3.50; Reverting scroll-bar face customization has no effect Stephen Berman
2020-10-30 13:20 ` Mauro Aranda
2020-10-30 13:30 ` Eli Zaretskii
2020-10-30 14:18 ` Mauro Aranda
2020-10-30 21:46 ` Stephen Berman
2020-10-31 9:08 ` Eli Zaretskii
2020-10-31 20:14 ` Mauro Aranda
2020-11-01 14:19 ` Stefan Monnier
[not found] ` <87bkyr68bf.fsf@yahoo.com>
2022-02-28 11:43 ` Mauro Aranda
2022-02-28 11:59 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-28 12:31 ` Mauro Aranda
2022-02-28 12:51 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-28 12:59 ` Mauro Aranda
2022-02-28 13:52 ` Eli Zaretskii
2022-02-28 14:04 ` Mauro Aranda
2022-02-28 14:49 ` Eli Zaretskii [this message]
2022-02-28 15:25 ` Mauro Aranda
2022-03-01 0:30 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-01 12:44 ` Eli Zaretskii
2022-03-01 12:48 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bkyrm4fv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=13476@debbugs.gnu.org \
--cc=luangruo@yahoo.com \
--cc=maurooaranda@gmail.com \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).