unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Antoine Kalmbach <ane@iki.fi>
Cc: 55847@debbugs.gnu.org
Subject: bug#55847: 29.0.50; line-number-at-pos ignores absolute parameter when checking position range
Date: Wed, 08 Jun 2022 17:02:32 +0300	[thread overview]
Message-ID: <83bkv35k3r.fsf@gnu.org> (raw)
In-Reply-To: <lyczfjcrcl.fsf@iki.fi> (message from Antoine Kalmbach on Wed, 08 Jun 2022 14:44:10 +0300)

tags 55847 notabug
thanks

> From: Antoine Kalmbach <ane@iki.fi>
> Date: Wed, 08 Jun 2022 14:44:10 +0300
> 
> 
> When working with a narrowed buffer, line-number-at-pos complains
> that the passed position parameter is out of range.
> 
> I believe this occurs because in fns.c there is check as follows:
> 
>    if (pos < BEGV || pos > ZV)

Yes, and that's by design.  With very rare exceptions, Emacs always
behaves as if text outside of the narrowed region doesn't exist.

This is not a bug.

> This works just fine when the buffer isn't narrowed, but narrowing
> affects BEGV. Suppose the buffer is narrowed, and you want to get the
> line number for position x where x is before where the current narrowing
> begins, passing (line-number-at-pos x t) now reports an error, because
> the correct thing to check is BEGV_BYTE, not BEGV.

You mean BEG, not BEGV_BYTE, I believe.  BEGV_BYTE is the _byte_
position corresponding to BEGV (which is a character position).

Anyway, if you want to get line-number-at-pos outside of the
restriction, you can simply do

  (save-restriction
    (widen)
    (line-number-at-pos POS))

This is what we do in Emacs if we want to access position outside of
the narrowed region.





  parent reply	other threads:[~2022-06-08 14:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-08 11:44 bug#55847: 29.0.50; line-number-at-pos ignores absolute parameter when checking position range Antoine Kalmbach
2022-06-08 12:52 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-08 14:02 ` Eli Zaretskii [this message]
2022-06-09  7:44   ` Antoine Kalmbach
2022-06-09 10:46     ` Lars Ingebrigtsen
2022-06-09 11:19       ` Antoine Kalmbach
2022-06-09 12:43         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bkv35k3r.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=55847@debbugs.gnu.org \
    --cc=ane@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).