From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56712: 29.0.50; x-dnd-tests-do-direct-save fails on Cygwin Date: Tue, 26 Jul 2022 05:38:53 +0300 Message-ID: <83bktcegxu.fsf@gnu.org> References: <35f58e97-4b26-d2ec-ce50-f5ffc7db366a@cornell.edu> <878rok4orj.fsf@yahoo.com> <874jz72qll.fsf@yahoo.com> <83edybgiue.fsf@gnu.org> <87fsir0yat.fsf@yahoo.com> <83a68yhotm.fsf@gnu.org> <8735eq1vq6.fsf@yahoo.com> <4f926531-f050-85c2-8826-5fa6def7f324@cornell.edu> <87wnc2ypgb.fsf@yahoo.com> <0669c533-4f60-50c5-21c1-ea779dedcee2@cornell.edu> <87mtcyymb4.fsf@yahoo.com> <193b54c8-c047-bb47-7430-f3719ac1e100@cornell.edu> <83ilnldtg9.fsf@gnu.org> <87zggwy66u.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26664"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56712@debbugs.gnu.org, kbrown@cornell.edu To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 26 04:39:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGATZ-0006kM-Jf for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 Jul 2022 04:39:13 +0200 Original-Received: from localhost ([::1]:58722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGATY-00057z-CB for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Jul 2022 22:39:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33570) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGATO-00057i-Q2 for bug-gnu-emacs@gnu.org; Mon, 25 Jul 2022 22:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33913) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oGATO-0000Pb-Gy for bug-gnu-emacs@gnu.org; Mon, 25 Jul 2022 22:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oGATO-0006qT-C3 for bug-gnu-emacs@gnu.org; Mon, 25 Jul 2022 22:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Jul 2022 02:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56712 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 56712-submit@debbugs.gnu.org id=B56712.165880313626300 (code B ref 56712); Tue, 26 Jul 2022 02:39:02 +0000 Original-Received: (at 56712) by debbugs.gnu.org; 26 Jul 2022 02:38:56 +0000 Original-Received: from localhost ([127.0.0.1]:51895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGATH-0006q7-V8 for submit@debbugs.gnu.org; Mon, 25 Jul 2022 22:38:56 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGATG-0006pq-UE for 56712@debbugs.gnu.org; Mon, 25 Jul 2022 22:38:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58990) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGATB-0000N5-6g; Mon, 25 Jul 2022 22:38:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3mLmCeS1SuA8OOBTkDPaxKXXy5FhYd4hrxayl+ohIFM=; b=D+/tgun7XMZk tftDFWOzUQu3ESUVVkfF3nxcMViWDFhLEuAkOfZ6p+cbsfVhsEK7WHyJkFNn2CsNf/tjREfABZ+Fz Cwnzmxz6CTnDyyHKdkoBQ8uZDkUdgFudKsBoR7tVXLFc3h08QQXPHcmNfICsczrwkFBqBM3uHTNQR LbBFDnIDmHac6HF3hoTWDywnPGF0Siw8DQ1nU2Ofj/IlM/jAm42GLeFueaL9LHpbNQnroOCE2myuP ib+AIMBxzMHF6GX4UPoI8NPh2aKAHmvVwoGDFwMKfQ/tmyySRskbAwVfXfPWKL3YGpjwelVVZWRm6 6qXD9brOLSCaRp4dbSKFgA==; Original-Received: from [87.69.77.57] (port=1293 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGATA-0006Y4-KX; Mon, 25 Jul 2022 22:38:48 -0400 In-Reply-To: <87zggwy66u.fsf@yahoo.com> (message from Po Lu on Tue, 26 Jul 2022 10:10:49 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237918 Archived-At: > From: Po Lu > Cc: Ken Brown , 56712@debbugs.gnu.org > Date: Tue, 26 Jul 2022 10:10:49 +0800 > > Eli Zaretskii writes: > > > FTR: if that test should ever run on native MS-Windows, we'd need that > > third slash, because file://c:/foo/bar is not valid on Windows, you > > must say file:///c:/foo/bar. > > > > So from my POV, it is best to make that code system-dependent, with > > windows-nt using 3 slashes, not 2. > > The code is specific to X -- as evidenced by the name. Doesn't Cygwin > (the only way I know of to get an X server on MS Windows) use Unix-style > file names everywhere? Yes, thus my "if this test should ever run" condition. IOW, the code produces 3 slashes by concatenating 2 strings, but the results are only correct on Posix filesystems. So at least a comment is in order there, because how long would it take, you think, for someone to copy/paste that code into an entirely different context?