From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: 56712@debbugs.gnu.org, kbrown@cornell.edu
Subject: bug#56712: 29.0.50; x-dnd-tests-do-direct-save fails on Cygwin
Date: Tue, 26 Jul 2022 05:38:53 +0300 [thread overview]
Message-ID: <83bktcegxu.fsf@gnu.org> (raw)
In-Reply-To: <87zggwy66u.fsf@yahoo.com> (message from Po Lu on Tue, 26 Jul 2022 10:10:49 +0800)
> From: Po Lu <luangruo@yahoo.com>
> Cc: Ken Brown <kbrown@cornell.edu>, 56712@debbugs.gnu.org
> Date: Tue, 26 Jul 2022 10:10:49 +0800
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > FTR: if that test should ever run on native MS-Windows, we'd need that
> > third slash, because file://c:/foo/bar is not valid on Windows, you
> > must say file:///c:/foo/bar.
> >
> > So from my POV, it is best to make that code system-dependent, with
> > windows-nt using 3 slashes, not 2.
>
> The code is specific to X -- as evidenced by the name. Doesn't Cygwin
> (the only way I know of to get an X server on MS Windows) use Unix-style
> file names everywhere?
Yes, thus my "if this test should ever run" condition.
IOW, the code produces 3 slashes by concatenating 2 strings, but the
results are only correct on Posix filesystems. So at least a comment
is in order there, because how long would it take, you think, for
someone to copy/paste that code into an entirely different context?
next prev parent reply other threads:[~2022-07-26 2:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 21:10 bug#56712: 29.0.50; x-dnd-tests-do-direct-save fails on Cygwin Ken Brown
2022-07-23 1:10 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-23 17:30 ` Ken Brown
2022-07-23 17:41 ` Ken Brown
2022-07-24 2:26 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-24 5:50 ` Eli Zaretskii
2022-07-24 7:23 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-24 7:42 ` Michael Albinus
2022-07-24 8:55 ` Eli Zaretskii
2022-07-24 10:55 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-24 13:33 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-24 15:40 ` Ken Brown
2022-07-25 1:02 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-25 1:42 ` Ken Brown
2022-07-25 2:10 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-25 16:24 ` Ken Brown
2022-07-25 16:53 ` Eli Zaretskii
2022-07-26 2:10 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-26 2:38 ` Eli Zaretskii [this message]
2022-07-26 2:52 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bktcegxu.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=56712@debbugs.gnu.org \
--cc=kbrown@cornell.edu \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).