From: Eli Zaretskii <eliz@gnu.org>
To: "Daniel Martín" <mardani29@yahoo.es>
Cc: 57420@debbugs.gnu.org
Subject: bug#57420: 29.0.50; Failure configuring Emacs with animated WebP support
Date: Fri, 26 Aug 2022 08:43:29 +0300 [thread overview]
Message-ID: <83bks736gu.fsf@gnu.org> (raw)
In-Reply-To: <m1fshkc7cj.fsf@yahoo.es> (bug-gnu-emacs@gnu.org)
> Date: Thu, 25 Aug 2022 23:59:40 +0200
> From: Daniel Martín via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> If WebP animated support requires -lwebpdemux, I think we could require
> the libwebpdemux module instead (part of the libwebp package), whose
> linker flags include "-lwebp -lwebpdemux". The following patch fixes
> the compilation for me:
>
> diff --git a/configure.ac b/configure.ac
> index 6ca3052ea3..4590ed3506 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2773,12 +2773,9 @@ AC_DEFUN
> || test "${HAVE_W32}" = "yes" || test "${HAVE_NS}" = "yes" \
> || test "${HAVE_BE_APP}" = "yes" || test "${HAVE_PGTK}" = "yes"; then
> WEBP_REQUIRED=0.6.0
> - WEBP_MODULE="libwebp >= $WEBP_REQUIRED"
> + WEBP_MODULE="libwebpdemux >= $WEBP_REQUIRED"
>
> EMACS_CHECK_MODULES([WEBP], [$WEBP_MODULE])
> - if test "$HAVE_WEBP" = "yes"; then
> - WEBP_LIBS="-lwebp -lwebpdemux"
> - fi
> AC_SUBST([WEBP_CFLAGS])
> AC_SUBST([WEBP_LIBS])
> fi
>
> I checked that the built Emacs has WebP support.
>
> What do you think?
LGTM, thanks.
prev parent reply other threads:[~2022-08-26 5:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m1fshkc7cj.fsf.ref@yahoo.es>
2022-08-25 21:59 ` bug#57420: 29.0.50; Failure configuring Emacs with animated WebP support Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-25 22:50 ` Stefan Kangas
2022-08-25 23:12 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-26 5:51 ` Eli Zaretskii
2022-08-26 20:40 ` Stefan Kangas
2022-08-27 6:37 ` Eli Zaretskii
2022-08-27 13:28 ` Lars Ingebrigtsen
2022-08-26 11:08 ` Lars Ingebrigtsen
2022-08-26 5:43 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bks736gu.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=57420@debbugs.gnu.org \
--cc=mardani29@yahoo.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).