From: Eli Zaretskii <eliz@gnu.org>
To: Gustaf Waldemarson <gustaf.waldemarson@gmail.com>
Cc: 59730@debbugs.gnu.org
Subject: bug#59730: gdb-mi.el: Local variables reordering
Date: Wed, 07 Dec 2022 19:50:44 +0200 [thread overview]
Message-ID: <83bkof3xxn.fsf@gnu.org> (raw)
In-Reply-To: <CABehr5cC9233O2xLiz3ErnPmg3LHszXxFfPtE3pjYq337R=sbg@mail.gmail.com> (message from Gustaf Waldemarson on Sun, 4 Dec 2022 15:26:22 +0100)
> From: Gustaf Waldemarson <gustaf.waldemarson@gmail.com>
> Date: Sun, 4 Dec 2022 15:26:22 +0100
> Cc: 59730@debbugs.gnu.org
>
> There I also noticed that that the `gdb-locals-value-limit'
> has become redundant with this change. Unfortunately, I wasn't able to figure out how
> to mark that defcustom as deprecated, is there some kind of macro that should be done
> for that, or should I just remove it?
I don't like making backwards-incompatible changes such as removing a
user option. How about if the default value of
gdb-locals-table-row-config used the value of gdb-locals-value-limit
instead of a literal 100?
> +** Variable order and truncation can now be configured in gdb-many-window mode.
> +The new variable `gdb-locals-table-row-config' allows users to
> +configure the order and max length of various properties in the local
> +variables frame.
^^^^^
"frame or window", right?
> +By default, this variable is set to write the properties in the order:
> +name, type and value. Where name and type are truncated to 20
^^
Our conventions are to use two spaces between sentences.
> +characters, and the value is truncated to 100.
> +
> +In order to restore the old display behavior, set
> +`gdb-locals-table-row-config' to '((type . 0)(name . 0)(value . 0)).
That value is incorrect, because the value was truncated at 100, due
to gdb-locals-value-limit, right?
> +Additionally, this behavior encompasses the actions of the old
> +`gdb-locals-value-limit' variable, which is no longer used and marked
> +deprecated.
I hope we won't need this paragraph.
Thanks.
next prev parent reply other threads:[~2022-12-07 17:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 22:09 bug#59730: gdb-mi.el: Local variables reordering Gustaf Waldemarson
2022-12-01 15:44 ` Eli Zaretskii
2022-12-01 20:40 ` Gustaf Waldemarson
2022-12-01 21:53 ` Gustaf Waldemarson
2022-12-02 13:48 ` Eli Zaretskii
2022-12-03 13:02 ` Gustaf Waldemarson
2022-12-03 19:58 ` Eli Zaretskii
2022-12-04 14:26 ` Gustaf Waldemarson
2022-12-07 17:50 ` Eli Zaretskii [this message]
2022-12-08 18:43 ` Gustaf Waldemarson
2022-12-10 13:29 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bkof3xxn.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=59730@debbugs.gnu.org \
--cc=gustaf.waldemarson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).