From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: 60144@debbugs.gnu.org, karl@karlotness.com
Subject: bug#60144: 30.0.50; PGTK Emacs crashes after signal
Date: Sun, 18 Dec 2022 14:33:22 +0200 [thread overview]
Message-ID: <83bko0gact.fsf@gnu.org> (raw)
In-Reply-To: <871qowgbay.fsf@yahoo.com> (message from Po Lu on Sun, 18 Dec 2022 20:12:53 +0800)
> From: Po Lu <luangruo@yahoo.com>
> Cc: karl@karlotness.com, 60144@debbugs.gnu.org
> Date: Sun, 18 Dec 2022 20:12:53 +0800
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> No, signalling there is equally unsafe on the other platforms, where
> >> note_mouse_highlight is called from the same place(s): read_socket_hook,
> >> event_handler_gdk, et cetera. Just look at the callers of
> >> x_note_mouse_movement in xterm.c, or [EmacsView mouseMoved:] in
> >> nsterm.m.
> >
> > Sorry, I'm afraid I don't see the danger on other platforms. Please
> > explain. AFAIK, read_socket_hook is called from keyboard.c code which
> > reads input, and that code has no problem signaling an error. What am
> > I missing?
>
> That code has problems signalling errors, unless it is okay for
> unblock_input to signal.
I don't understand this part. Why and how is unblock_input part of
the picture?
> On the regular X build with GTK, handle_one_xevent is called from
> event_handler_gdk, which is called by GDK when it detects an event.
> handle_one_xevent can also be called from x_dispatch_event inside a
> popup menu, and during drag-and-drop. On NS, [EmacsView mouseMoved:] is
> called by the system from Objective-C.
So in the X/GTK build we have the same problem as with PGTK? If so,
why not change that as well, to work as I described, i.e. enqueue
events to our own event queue, which we will then read and process in
safe context?
AFAIU, w32 already works like that. Does it not?
(As for NS, I know it does some very dangerous stuff.)
> Out of all of those places, the only place where it is safe to signal is
> inside the drag-and-drop event loop. Signalling out of the rest will
> either lead to catastrophic blowups (if it happens inside
> event_handler_gdk or [EmacsView mouseMoved:]), or to grabs never being
> released and resource leaks inside a menu.
Yes, understood. But it just tells me that we need to change the
architecture so that the events delivered by the window-system are not
processed in callbacks we install to be called by the window-system,
they should be processed in our own safe context.
next prev parent reply other threads:[~2022-12-18 12:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-17 3:39 bug#60144: 30.0.50; PGTK Emacs crashes after signal Karl Otness via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-18 2:08 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-18 5:45 ` Eli Zaretskii
2022-12-18 6:22 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-18 8:39 ` Eli Zaretskii
2022-12-18 9:52 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-18 11:43 ` Eli Zaretskii
2022-12-18 12:12 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-18 12:33 ` Eli Zaretskii [this message]
2022-12-18 13:45 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-18 17:34 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bko0gact.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=60144@debbugs.gnu.org \
--cc=karl@karlotness.com \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).