From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61326: [DRAFT PATCH] Work around zip's filename extension limitation (was: Adding --no-add-suffix to zip patch) Date: Wed, 08 Feb 2023 20:02:03 +0200 Message-ID: <83bkm4nihw.fsf@gnu.org> References: <87ilgeoc4w.fsf@tullinup.koldfront.dk> <8574C128-9560-490A-88E6-49E415BBDB24@netyu.xyz> <83k00up32i.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16767"; mail-complaints-to="usenet@ciao.gmane.io" Cc: asjo@koldfront.dk, 61326@debbugs.gnu.org To: Ruijie Yu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 08 19:02:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pPom1-00047l-5i for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Feb 2023 19:02:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPolg-0004Qz-Hv; Wed, 08 Feb 2023 13:02:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPole-0004QT-Gl for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2023 13:02:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPole-000727-7m for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2023 13:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pPole-0007TT-2k for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2023 13:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Feb 2023 18:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61326 X-GNU-PR-Package: emacs Original-Received: via spool by 61326-submit@debbugs.gnu.org id=B61326.167587931728721 (code B ref 61326); Wed, 08 Feb 2023 18:02:02 +0000 Original-Received: (at 61326) by debbugs.gnu.org; 8 Feb 2023 18:01:57 +0000 Original-Received: from localhost ([127.0.0.1]:56610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPolY-0007TA-Sw for submit@debbugs.gnu.org; Wed, 08 Feb 2023 13:01:57 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:32790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPolW-0007Sw-19 for 61326@debbugs.gnu.org; Wed, 08 Feb 2023 13:01:56 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPolP-0006pL-8F; Wed, 08 Feb 2023 13:01:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=BoxoKAZtJVM3JvLmf50OG8cK0pc1yENRZ1vYDDy0Rg8=; b=Dh5NG9mWb26U /n0chN0UmtzV8VDFs60RU6hID8I1MB1Gtwu8GguKMzvC6V1FD9H9UEFAx/+Ux7w814Xb4qaVLLVOF cOTN1j/GUWUm3Q4X72/6ZeQJrSogt+QKnkrGcd58gRJ9N1D/4TRXIb1Q7MgvyMdyFPn1VZ+BDC6TH lSbz2t9In8cQ8Cgcma9V4hHa3kaPabSj3kQSFJ89OKu036fRWyyVHycxwizKKh4dRhT27puvZ4yxa s0q0s+yyvN2APj91xjR6Nxe1p4A8UtM2YMznROlQED0azl7kDiulkKUPnc53NWToKPw8Hh4AKk4PK NJYDhdoAGxJJ3Ez+9vDeXA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPolO-0008TP-FC; Wed, 08 Feb 2023 13:01:46 -0500 In-Reply-To: (message from Ruijie Yu on Thu, 09 Feb 2023 00:48:15 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255156 Archived-At: > From: Ruijie Yu > Cc: Eli Zaretskii , asjo@koldfront.dk > Date: Thu, 09 Feb 2023 00:48:15 +0800 > > Here is a preliminary patch that contains some "REVIEW" comments where I > need inputs. Thanks, but could you perhaps post diffs disregarding the whitespace changes? That would make it easier to review the real changes. > -(defun archive-*-write-file-member (archive descr command) > +;; REVIEW: is there a better name than AVOID-EXTLESS-P? > +(defun archive-*-write-file-member (archive descr command > + &optional avoid-extless-p) ensure-extension? > + ;; REVIEW: the diff here is because the previous code had TAB's > + ;; (while assuming each TAB is 4 spaces), and my Emacs replaced > + ;; them with spaces. What is the status quo on this kind of diff? > + ;; I can remove them if we consider this change excessive and/or > + ;; intrusive. TABs in Emacs are by default 8 columns, not 4. It is OK to convert TABs to spaces when changing the code in Lisp, but please do that only for the last commit, to make the review process easier. For all the draft versions, please use "git diff" options that cause Git to ignore changes in whitespace. Thanks.