From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61962: 30.0.50; New trouble with symbols with positions Date: Mon, 13 Mar 2023 16:50:36 +0200 Message-ID: <83bkkwu2mb.fsf@gnu.org> References: <877cvvqj5v.fsf@web.de> <877cvv0yv7.fsf@web.de> <87a60p4d5q.fsf@web.de> <83356g7lh7.fsf@gnu.org> <87o7p4pt3p.fsf@gmail.com> <0166B01B-96AA-4A7D-B7F1-13A34C768C41@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2969"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, mattiase@acm.org, rpluim@gmail.com, 61962@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 13 15:51:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbjW8-0000U0-Fc for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Mar 2023 15:51:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pbjVw-0003wa-VK; Mon, 13 Mar 2023 10:51:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pbjVu-0003wO-Ax for bug-gnu-emacs@gnu.org; Mon, 13 Mar 2023 10:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pbjVt-0004qc-Ow for bug-gnu-emacs@gnu.org; Mon, 13 Mar 2023 10:51:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pbjVt-0001sJ-LI for bug-gnu-emacs@gnu.org; Mon, 13 Mar 2023 10:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Mar 2023 14:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61962 X-GNU-PR-Package: emacs Original-Received: via spool by 61962-submit@debbugs.gnu.org id=B61962.16787190547193 (code B ref 61962); Mon, 13 Mar 2023 14:51:01 +0000 Original-Received: (at 61962) by debbugs.gnu.org; 13 Mar 2023 14:50:54 +0000 Original-Received: from localhost ([127.0.0.1]:35375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbjVm-0001rx-3W for submit@debbugs.gnu.org; Mon, 13 Mar 2023 10:50:54 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbjVk-0001rf-6E for 61962@debbugs.gnu.org; Mon, 13 Mar 2023 10:50:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pbjVe-0004oI-8B; Mon, 13 Mar 2023 10:50:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=u3ta3q+/W7XwqDqRFOe6R+Ejmv1o22urwN/6+DmduAg=; b=pmNpRs+BPzz9uy/ppd+F 0w09teG7NGArUJ80y3TDQ1Q/Q/O6i2MFc22jX0zlOh8bO/M+ewznrfXBJwGN2HrxcChg34gIjeb6h IQa9nu/kkC2sFIc1ghAZugwlxCiprgjQCF+MFuBDDqAcqCnOelokBG7P9MA2y8rIOA78XBqYAxF8f fwa6b+uK6MAEZPS1R86s3m/xTO2jy27jhlgxtc8xQsR0qyCwNNlgAT3IfZ297Dtv7T6yvnQj4K9Vg y1WK9ohmLtC11MAqAxoKA5MQ521jePW+anlym3K8Ah/tseGQTaAORZoKpGIQJVlAAonLzuXehJJ4v 6pz5T5CtXdc49A==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pbjVd-00079R-Fw; Mon, 13 Mar 2023 10:50:45 -0400 In-Reply-To: (message from Alan Mackenzie on Sun, 12 Mar 2023 20:42:25 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257906 Archived-At: > Date: Sun, 12 Mar 2023 20:42:25 +0000 > Cc: Robert Pluim , Eli Zaretskii , > Michael Heerdegen , 61962@debbugs.gnu.org > From: Alan Mackenzie > > On Sun, Mar 12, 2023 at 18:30:51 +0100, Mattias Engdegård wrote: > > As promised earlier, I gave the safe-copy-tree code a good > > working-through. Testing revealed bugs but the new implementation > > shouldn't have them. It's internal for now as there seems to be no need > > for it elsewhere, which also permitted some gold-plating to be removed. > > The new code is also quite a bit faster. > > I'm not at all happy with the changes you've made. I'm not happy at all. Mattias, this kind of modus operandi is only acceptable if the original author installed something completely unreasonable or clearly broken. In all other cases, please present the proposed changes and their motivation, and wait for the discussion to converge before installing. Please don't do this again. Bonus points for reverting your changes and starting the discussion now.