unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: michael_heerdegen@web.de, mattiase@acm.org, rpluim@gmail.com,
	61962@debbugs.gnu.org
Subject: bug#61962: 30.0.50; New trouble with symbols with positions
Date: Mon, 13 Mar 2023 16:50:36 +0200	[thread overview]
Message-ID: <83bkkwu2mb.fsf@gnu.org> (raw)
In-Reply-To: <ZA45MbCu+62NgE7o@ACM> (message from Alan Mackenzie on Sun, 12 Mar 2023 20:42:25 +0000)

> Date: Sun, 12 Mar 2023 20:42:25 +0000
> Cc: Robert Pluim <rpluim@gmail.com>, Eli Zaretskii <eliz@gnu.org>,
>   Michael Heerdegen <michael_heerdegen@web.de>, 61962@debbugs.gnu.org
> From: Alan Mackenzie <acm@muc.de>
> 
> On Sun, Mar 12, 2023 at 18:30:51 +0100, Mattias Engdegård wrote:
> > As promised earlier, I gave the safe-copy-tree code a good
> > working-through. Testing revealed bugs but the new implementation
> > shouldn't have them. It's internal for now as there seems to be no need
> > for it elsewhere, which also permitted some gold-plating to be removed.
> > The new code is also quite a bit faster.
> 
> I'm not at all happy with the changes you've made.

I'm not happy at all.

Mattias, this kind of modus operandi is only acceptable if the
original author installed something completely unreasonable or clearly
broken.  In all other cases, please present the proposed changes and
their motivation, and wait for the discussion to converge before
installing.

Please don't do this again.  Bonus points for reverting your changes
and starting the discussion now.





  reply	other threads:[~2023-03-13 14:50 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-04 16:18 bug#61962: 30.0.50; New trouble with symbols with positions Michael Heerdegen
2023-03-04 16:34 ` Eli Zaretskii
2023-03-04 21:39   ` Mattias Engdegård
2023-03-04 21:53     ` Michael Heerdegen
2023-03-05 16:04     ` Michael Heerdegen
2023-03-05 18:39       ` Alan Mackenzie
2023-03-05 19:41         ` Michael Heerdegen
2023-03-06 13:22           ` Alan Mackenzie
2023-03-07  0:29             ` Michael Heerdegen
2023-03-07 10:24               ` Alan Mackenzie
2023-03-07 13:13                 ` Eli Zaretskii
2023-03-07 13:51                   ` Robert Pluim
2023-03-07 15:46                     ` Alan Mackenzie
2023-03-12 17:30                       ` Mattias Engdegård
2023-03-12 20:42                         ` Alan Mackenzie
2023-03-13 14:50                           ` Eli Zaretskii [this message]
2023-03-14 12:31                           ` Mattias Engdegård
2023-03-07 15:42                   ` Alan Mackenzie
2023-03-07 15:15                 ` Michael Heerdegen
2023-03-04 16:36 ` Eli Zaretskii
2023-03-04 16:47   ` Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bkkwu2mb.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=61962@debbugs.gnu.org \
    --cc=acm@muc.de \
    --cc=mattiase@acm.org \
    --cc=michael_heerdegen@web.de \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).