From: Eli Zaretskii <eliz@gnu.org>
To: "lux" <lx@shellcodes.org>
Cc: 62435@debbugs.gnu.org
Subject: bug#62435: [PATCH] 29.0 Fix eww--download-directory on MS-Windows
Date: Sat, 25 Mar 2023 16:25:52 +0300 [thread overview]
Message-ID: <83bkkhc68v.fsf@gnu.org> (raw)
In-Reply-To: <tencent_063B041F701ACE10D6C0D4CCDC81CACB870A@qq.com> (lx@shellcodes.org)
> From: "lux" <lx@shellcodes.org>
> Date: Sat, 25 Mar 2023 19:56:43 +0800
>
> The eww--download-directory hardcodes the download path, so it does not
> work on MS-Windows, I fixed it, and tested on MS-Windows.
Thanks, but this isn't the right fix. The code does want to honor the
user's "Downloads" subdirectory, even on Windows. In addition,
USERPROFILE only works on latest Windows versions.
I think the right fix here is to make this directory a defcustom, and
leave its default value at "~/Downloads" on all systems.
next prev parent reply other threads:[~2023-03-25 13:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 11:56 bug#62435: [PATCH] 29.0 Fix eww--download-directory on MS-Windows lux
2023-03-25 13:25 ` Eli Zaretskii [this message]
2023-03-25 13:42 ` lux
2023-03-25 14:05 ` Eli Zaretskii
2023-03-25 14:17 ` lux
2023-03-26 11:59 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bkkhc68v.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=62435@debbugs.gnu.org \
--cc=lx@shellcodes.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).