From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56682: feature/improved-locked-narrowing 9dee6df39c: Reworked locked narrowing. Date: Sun, 02 Apr 2023 08:16:00 +0300 Message-ID: <83bkk6yicv.fsf@gnu.org> References: <166939872890.18950.12581667269687468681@vcs2.savannah.gnu.org> <83bkmaueib.fsf@gnu.org> <83357fnwyy.fsf@gnu.org> <83ttzsk6v4.fsf@gnu.org> <83wn4le8s3.fsf@gnu.org> <0f053182b02103503c26@heytings.org> <83pmaccnz7.fsf@gnu.org> <0f053182b04357300cb1@heytings.org> <83lel0chku.fsf@gnu.org> <0f053182b00a59a41caa@heytings.org> <835yc3cdhk.fsf@gnu.org> <9e9ed8043fc8bfe49bfe@heytings.org> <83h6vnaukn.fsf@gnu.org> <9e9ed8043f4ff9316461@heytings.org> <83k00exj56.fsf@gnu.org> <10ececa33f0a4af46fd2@heytings.org> <83edp3zwjk.fsf@gnu.org> <83r0t3y6yy.fsf@gnu.org> <83lejby3nk.fsf@gnu.org> <83h6tzy19k.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39094"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56682@debbugs.gnu.org, monnier@iro.umontreal.ca To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 02 07:16:09 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1piq4W-000A0L-Lm for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Apr 2023 07:16:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1piq4S-000844-Op; Sun, 02 Apr 2023 01:16:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piq4Q-00083N-VD for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2023 01:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1piq4Q-0008PI-NR for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2023 01:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1piq4Q-0000W2-IR for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2023 01:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Apr 2023 05:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.16804125521957 (code B ref 56682); Sun, 02 Apr 2023 05:16:02 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 2 Apr 2023 05:15:52 +0000 Original-Received: from localhost ([127.0.0.1]:38968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piq4F-0000VU-KH for submit@debbugs.gnu.org; Sun, 02 Apr 2023 01:15:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piq4D-0000VE-QC for 56682@debbugs.gnu.org; Sun, 02 Apr 2023 01:15:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piq47-0008Ly-P6; Sun, 02 Apr 2023 01:15:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GPZymV1f9ljYPwrqDE/iuMURWUL6KYuodz94V9KKtgk=; b=JdWL3VJFNSMz F7BvIVN6nw33krUTd4GUshxkU8kzGSmU5WiQrHgmA+GfmhZJDfb2JdIszpHCaomgHIMl4WosM/QlB 1wHIOWPtfwTTYW/6NJ0D3ZG6lS04M6pchyp4aNHev3oioR/QMSu/PcPnYGGvSNmJAb4tthaGZKjHN fOV4NkW0YSMEIdJpGzkigz2cidEvyfdxV/LCRMgPsSlmBQTzPVthFWU8VR6k9zpmtKnaKOxyVFT3x VUHEdhvf8OW3pB2RLpbi1K/5LJHOrZ1/ZW4KR4cZaDUt7dtr2yTMlegreq+bj5QYt92zdjc6s5VFt JdVvdoE7G8dCOY3f4rETNg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piq46-0001Ml-Lb; Sun, 02 Apr 2023 01:15:43 -0400 In-Reply-To: (message from Gregory Heytings on Sat, 01 Apr 2023 21:56:20 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259087 Archived-At: > Date: Sat, 01 Apr 2023 21:56:20 +0000 > From: Gregory Heytings > cc: 56682@debbugs.gnu.org, monnier@iro.umontreal.ca > > > >> Thanks. Done in 097c5ee8f5, together with the FRAME_WINDOW_P fix. Do > >> you have other comments/reservations? > > > > Not specific ones, no. I just hope there are no hidden rocks there, as > > this code was not well tested. > > That's what I hope, too. But the risks are really small here, the only > potential problem I can imagine would be some kind of error in > 'get_nearby_bol_pos', but I don't see where it could possibly fail. Famous last words... > I made a few final fixes; I guess I can now merge that branch? Yes, fingers crossed.