From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63221: 30.0.50; [PATCH] Eshell should get user (and group) IDs in a connection-aware fashion Date: Tue, 02 May 2023 14:58:39 +0300 Message-ID: <83bkj3ndw0.fsf@gnu.org> References: <473147ec-87a1-8a2a-9062-bbdef41da3ac@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3365"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63221@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 02 13:59:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ptof7-0000fF-Tl for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 May 2023 13:59:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptoeu-0006Vc-3U; Tue, 02 May 2023 07:59:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptoet-0006VS-7J for bug-gnu-emacs@gnu.org; Tue, 02 May 2023 07:59:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptoes-0005CG-Lo for bug-gnu-emacs@gnu.org; Tue, 02 May 2023 07:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ptoes-0000qL-1S for bug-gnu-emacs@gnu.org; Tue, 02 May 2023 07:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 May 2023 11:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63221 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63221-submit@debbugs.gnu.org id=B63221.16830286853175 (code B ref 63221); Tue, 02 May 2023 11:59:02 +0000 Original-Received: (at 63221) by debbugs.gnu.org; 2 May 2023 11:58:05 +0000 Original-Received: from localhost ([127.0.0.1]:41862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptodx-0000p9-2l for submit@debbugs.gnu.org; Tue, 02 May 2023 07:58:05 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptodt-0000od-TO for 63221@debbugs.gnu.org; Tue, 02 May 2023 07:58:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptodo-0004vY-GY; Tue, 02 May 2023 07:57:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=cLfgNPhFigEAHH2LmU5JHZjk9liInaVVxzP35Eu2How=; b=dOiG3srD3bZU uP1pKOxVYypzAOJmHZlrSD/0wNsK1wwVV7v0JJo4OOSRUBEO68HgUOvwuxWPeTbJJDRfDG50YGfBT BwuywrNL0dEJKOFiJxu404tRkq7GHLV0N0Xd4tL1Db52d+0BRU53HkaWPQIreJjRn3S82M+OJg+P8 InuMYObYi6aHQ9Pe2o3u9qs6G0SPFYthNQpJM7/sgd8xZd1jyv6dctXxGXomclIjmVNChodCORVQy tClgUDWt/XZXwTTuhij+8GbkwazLzDcJ84Bk0BWOwGHC3syMW4fUtSayDYXtSWGG7HJEqVu/TEx7g ul87lWV6x21mZ9Gbd7Axrw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptodn-00053M-LJ; Tue, 02 May 2023 07:57:55 -0400 In-Reply-To: <473147ec-87a1-8a2a-9062-bbdef41da3ac@gmail.com> (message from Jim Porter on Mon, 1 May 2023 22:42:53 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260914 Archived-At: > Date: Mon, 1 May 2023 22:42:53 -0700 > From: Jim Porter > > -(defcustom eshell-rm-interactive-query (= (user-uid) 0) > - "If non-nil, `rm' will query before removing anything." > - :type 'boolean > +(define-widget 'eshell-interactive-query 'lazy > + "When to interatively query the user about a particular operation." This terse sentence needs to be explained in the rest of the doc string, because, unlike "If non-nil", "When" does not explain itself. The doc string should explain how to specify "when". It should also explain the different supported values. > + :tag "Query" > + :type '(choice (const :tag "Never" nil) > + (const :tag "Always" t) > + (const :tag "When root" root))) Also, the default value is not one of the possible optional values. Same comment to the other similar defcustoms where you changed a boolean option to something else: their doc strings are now obfuscated. > +(defun eshell-interactive-query-p (value) > + "Return non-nil if a command should query the user according to VALUE. > +If VALUE is `root', return non-nil when evaluated as root (see > +`file-user-uid'). Otherwise, simply return VALUE." You assume here that "evaluated as root" explains itself? I wouldn't rely on that. Thanks.