From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63260: 29.0.90; Regression installing/activating packages without autoloads Date: Sat, 06 May 2023 12:01:07 +0300 Message-ID: <83bkixhm0c.fsf@gnu.org> References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> <87zg6kysao.fsf@tcd.ie> <87lei3nv24.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30526"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contovob@tcd.ie, 63260@debbugs.gnu.org, philipk@posteo.net To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 06 11:01:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvDn1-0007lC-CQ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 May 2023 11:01:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvDmp-0000wx-C3; Sat, 06 May 2023 05:01:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvDmo-0000wo-LR for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 05:01:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvDmo-00007m-AH for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 05:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pvDmo-0006fk-59 for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 05:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 May 2023 09:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63260 X-GNU-PR-Package: emacs Original-Received: via spool by 63260-submit@debbugs.gnu.org id=B63260.168336362525596 (code B ref 63260); Sat, 06 May 2023 09:01:02 +0000 Original-Received: (at 63260) by debbugs.gnu.org; 6 May 2023 09:00:25 +0000 Original-Received: from localhost ([127.0.0.1]:59401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvDmD-0006em-7a for submit@debbugs.gnu.org; Sat, 06 May 2023 05:00:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvDmA-0006eV-BG for 63260@debbugs.gnu.org; Sat, 06 May 2023 05:00:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvDm4-0008RG-8Q; Sat, 06 May 2023 05:00:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=oLtQT9S7V7eUm6Mq0BLSqUUJpvvXogj+nHqoswGyb1E=; b=TeMaUHSY5l/SLEG+05yN 7oq9FuA5bV8FWIIRpN1B6Iikko/LmupRPpH69KqOWPg0IgaqymmoWNjRbz/y1BZzYvX9c/UoRV72P XJIbHmetTprUkJROywCheweE2paQTjsaItNASibiGfszCtHTAVpEYuBzisVvyhIgq/eHKPVwXRx4r iXbp2FNgkLTinSe66V4MYYkO1U/OKL26yhrgod7d/ZPW5ZGlw+Srcc3QZpZsjpr+3oqpcV2s6p7ku 4fvIQicdWuG3js+NsOYa0wQgBQlhfMIbwB3jESkD34B2aVf30kx+BbQtBck4/X8nVkC5TwLOh+Kuo rimFR3qcXMCBeg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvDm0-0001dT-Bi; Sat, 06 May 2023 05:00:16 -0400 In-Reply-To: <87lei3nv24.fsf@gmail.com> (message from Robert Pluim on Fri, 05 May 2023 08:36:51 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261168 Archived-At: > Cc: 63260@debbugs.gnu.org, Philip Kaludercic > From: Robert Pluim > Date: Fri, 05 May 2023 08:36:51 +0200 > > >>>>> On Thu, 04 May 2023 18:28:47 +0200, Basil Contovounesios said: > > Basil> This does not address the file-missing error during package activation, > Basil> but it allows a subsequent package-quickstart-refresh to complete > Basil> (albeit with a warning in a *Compile-Log*): > > The file-missing error is expected, no? Thatʼs why the autoloads > loading is wrapped in `with-demoted-errors'. Although if the message bothers > you, I guess we could check `file-exists-p' for it. > > Basil> Compiling file /tmp/tmp.6cdF8paE0K/.emacs.d/package-quickstart.el > Basil> at Thu May 4 18:24:07 2023 > Basil> Entering directory ‘/tmp/tmp.6cdF8paE0K/.emacs.d/’ > Basil> package-quickstart.el:4:2: Warning: Empty let body > > Basil> due to the following generated contents of package-quickstart-file: > > Basil> (let ((load-true-file-name nil)(load-file-name nil)) > Basil> ) > > Iʼd claim ENOCOFFEE for the last patch, but it was not the morning :-) > > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index 0919ce34448..4b488281b78 100644 > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -4491,11 +4491,11 @@ package-quickstart-refresh > (insert ";;; Quickstart file to activate all packages at startup -*- lexical-binding:t -*-\n") > (insert ";; ¡¡ This file is autogenerated by `package-quickstart-refresh', DO NOT EDIT !!\n\n") > (dolist (pkg package--quickstart-pkgs) > - (let* ((file > - ;; Prefer uncompiled files (and don't accept .so files). > - (let ((load-suffixes '(".el" ".elc"))) > - (locate-library (package--autoloads-file-name pkg)))) > - (pfile (prin1-to-string file))) > + (when-let* ((file > + ;; Prefer uncompiled files (and don't accept .so files). > + (let ((load-suffixes '(".el" ".elc"))) > + (locate-library (package--autoloads-file-name pkg)))) > + (pfile (prin1-to-string file))) > (insert "(let ((load-true-file-name " pfile ")\ > \(load-file-name " pfile "))\n") > (insert-file-contents file) > Philip, Basil: is the above okay with you? I'd like this issue resolved before making the next pretest of Emacs 29.1. Thanks.