From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56682: feature/improved-locked-narrowing 9dee6df39c: Reworked locked narrowing. Date: Wed, 10 May 2023 17:00:35 +0300 Message-ID: <83bkis8ews.fsf@gnu.org> References: <166939872890.18950.12581667269687468681@vcs2.savannah.gnu.org> <0f053182b02103503c26@heytings.org> <83pmaccnz7.fsf@gnu.org> <0f053182b04357300cb1@heytings.org> <83lel0chku.fsf@gnu.org> <0f053182b00a59a41caa@heytings.org> <835yc3cdhk.fsf@gnu.org> <9e9ed8043fc8bfe49bfe@heytings.org> <83h6vnaukn.fsf@gnu.org> <9e9ed8043f4ff9316461@heytings.org> <83k00exj56.fsf@gnu.org> <10ececa33f0a4af46fd2@heytings.org> <83edp3zwjk.fsf@gnu.org> <83r0t3y6yy.fsf@gnu.org> <83lejby3nk.fsf@gnu.org> <83h6tzy19k.fsf@gnu.org> <83bkk6yicv.fsf@gnu.org> <83jzxoll20.fsf@gnu.org> <221c67168567a20a89c1@heytings.org> <834joqiyuq.fsf@gnu.org> <83mt2igelb.fsf@gnu.org> <24b4118b217952fab8dd@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21618"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56682@debbugs.gnu.org, monnier@iro.umontreal.ca To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 10 16:00:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pwkMh-0005RR-QA for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 May 2023 16:00:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwkMV-0003il-16; Wed, 10 May 2023 10:00:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwkMN-0003hy-1t for bug-gnu-emacs@gnu.org; Wed, 10 May 2023 10:00:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pwkMM-0004I5-OJ for bug-gnu-emacs@gnu.org; Wed, 10 May 2023 10:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pwkMM-00074P-94 for bug-gnu-emacs@gnu.org; Wed, 10 May 2023 10:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 May 2023 14:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.168372718227121 (code B ref 56682); Wed, 10 May 2023 14:00:02 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 10 May 2023 13:59:42 +0000 Original-Received: from localhost ([127.0.0.1]:48518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwkM1-00073M-Ob for submit@debbugs.gnu.org; Wed, 10 May 2023 09:59:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwkLy-000732-Rj for 56682@debbugs.gnu.org; Wed, 10 May 2023 09:59:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwkLs-0004AL-68; Wed, 10 May 2023 09:59:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=eXCUWdkA/UNTsclaHYU/86W2ehhI4tcmTUFkPOM1Ki4=; b=qIot66Msf1QO cNNcckqBAl6YimSAcjJrlXUD2luePfU8Kyv7hEhp7Pdevuo8cp5B7AUPq843dJKVNcxkkv2uj4IZ6 Bz4F2h6m4oVE+ZGRuNoTHmiYtVBuljrnVTWkulXEax8M4smWIAULQ++5kz4LOYP7Er5i0m5hCuHUs mp7FGfN0oOYnckJiJBxuZ9ou6WLuuLuGJ/jLGzY9Quq62E9oF0bzWjhb+ES/HsHAwOU0m2DP2FtzT 4QhYURtBTzoFENcBGz4sZ/TTabW5xZ7zPkK2KND+trU2auNINlLYbpNi4rpEr8OMQw3Er+YRUYiTG UpUvtP1FvQvViQmoRXpEBQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwkLp-0005mY-A6; Wed, 10 May 2023 09:59:31 -0400 In-Reply-To: <24b4118b217952fab8dd@heytings.org> (message from Gregory Heytings on Tue, 09 May 2023 21:48:42 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261497 Archived-At: > Date: Tue, 09 May 2023 21:48:42 +0000 > From: Gregory Heytings > cc: 56682@debbugs.gnu.org, monnier@iro.umontreal.ca > > > I'd prefer to use a marker there, but that can be a separate changeset. > > > > Can you confirm that the attached patch is what you would prefer? IMHO it > is better/clearer to have a single call to XMARKER in > 'labeled_restrictions_get_bound', instead of having to repeat it > everywhere its return value is used. The price is indeed that the > signature of that (internal) function is unusual. (Note that we cannot > wrap the calls to 'labeled_restrictions_get_bound' in a call to XMARKER, > because it can return nil.) Yes, this is what I meant, but please use marker_position and marker_byte_position instead of accessing the object directly. Thanks.