From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63731: [PATCH] Support Emoji Variation Sequence 16 (FE0F) where appropriate Date: Mon, 29 May 2023 17:55:49 +0300 Message-ID: <83bki3gpai.fsf@gnu.org> References: <87a5xrzsph.fsf@stebalien.com> <83pm6nlhll.fsf@gnu.org> <87v8gfmqyt.fsf@gmail.com> <83ilcflbua.fsf@gnu.org> <87mt1rmjjg.fsf@gmail.com> <83v8gfjnzj.fsf@gnu.org> <87edn3mbr3.fsf@gmail.com> <83mt1rjg69.fsf@gnu.org> <875y8fm7x7.fsf@gmail.com> <83lehbjdjd.fsf@gnu.org> <87wn0vkqn1.fsf@gmail.com> <83jzwvj94x.fsf@gnu.org> <87h6rw8y82.fsf@gmail.com> <83353gipww.fsf@gnu.org> <87edmzto0l.fsf@gmail.com> <83ilcbgrxo.fsf@gnu.org> <87zg5nb3m3.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3675"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63731@debbugs.gnu.org, steven@stebalien.com To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 29 16:56:36 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q3eIV-0000kg-9O for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 May 2023 16:56:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q3eI8-0006Qk-L9; Mon, 29 May 2023 10:56:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3eHy-0006QN-Vc for bug-gnu-emacs@gnu.org; Mon, 29 May 2023 10:56:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q3eHy-0006hl-NO for bug-gnu-emacs@gnu.org; Mon, 29 May 2023 10:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q3eHy-0001kd-Jr for bug-gnu-emacs@gnu.org; Mon, 29 May 2023 10:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 May 2023 14:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63731 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63731-submit@debbugs.gnu.org id=B63731.16853721356685 (code B ref 63731); Mon, 29 May 2023 14:56:02 +0000 Original-Received: (at 63731) by debbugs.gnu.org; 29 May 2023 14:55:35 +0000 Original-Received: from localhost ([127.0.0.1]:58869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3eHW-0001jl-Ge for submit@debbugs.gnu.org; Mon, 29 May 2023 10:55:34 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3eHU-0001jS-JV for 63731@debbugs.gnu.org; Mon, 29 May 2023 10:55:33 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3eHN-0006OR-HC; Mon, 29 May 2023 10:55:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=wtWpSw40l1Ta7dbpINytTF6QN8ILA3j5GXoehHJ/y8E=; b=Z7M4nAZ23INW+LzDNJHk YsyORbm3VwfIzQLng+NseUkNJ0Iw5ChNb5J3UZaomgXA8bng7vHUy1/2oxw8+Nq5ZIeniYFkbA/X1 SkviwWer36QXUh6YKjSvMbey3G3I085Oc1rtj97OrxumXtiXJQsrycUkaY/yo3zPnfnWwtqFS5cut 8Oteh1Bhyne+ap0DfV6E0QEwfgJsBitBAqC4LZjudLFnKAcgvaHcFIM+Ka4HLftyN9chklnTdiNb6 B+MGIPTGca53jye95Y3LxKaS9QCwfU8muxuHdMRkV51Mq4ZYdXEjyrxE8YmFpVIW/jdZQhysAtAxy 0TJHNAXV3K+etw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3eH8-0005LG-BD; Mon, 29 May 2023 10:55:25 -0400 In-Reply-To: <87zg5nb3m3.fsf@gmail.com> (message from Robert Pluim on Mon, 29 May 2023 16:43:00 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262589 Archived-At: > From: Robert Pluim > Cc: 63731@debbugs.gnu.org, steven@stebalien.com > Date: Mon, 29 May 2023 16:43:00 +0200 > > >>>>> On Mon, 29 May 2023 16:58:43 +0300, Eli Zaretskii said: > > >> display: composed to form "👍️" (see below) > > Eli> This is not what I see. I didn't use the above set-char-table-range > Eli> expression literally, but instead started "emacs -Q", and then > Eli> evaluated in *scratch*: > > Eli> (set-char-table-range > Eli> composition-function-table > Eli> #xFE0F > Eli> '(["\\c.\ufe0f" 1 compose-gstring-for-graphic])) > > Eli> After that, the sequence U+1F44D U+FE0F displays as a single glyph, > Eli> and there's no thin space after it. What am I missing? Is this > Eli> somehow specific to ftcrhb font driver or something? > > Itʼs a single glyph, but that glyph contains a thin-space. I used this > to check, the second 'a' is slightly offset > > 👍️a > 👍a That's because the first one shows two glyphs that are "pseudo-composed": not by the font, but by our hand-made "composition" in compose-gstring-for-graphic. Try this instead: (set-char-table-range composition-function-table #xFE0F '(["\\c.\ufe0f" 1 font-shape-gstring])) so that we only see a composition if the font indeed agrees to compose. What do you see?