From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63844: 30.0.50; [PATCH] Revert Python mode multiline font-lock Date: Sat, 03 Jun 2023 10:12:42 +0300 Message-ID: <83bkhx9fyt.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25079"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63844@debbugs.gnu.org To: kobarity Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 03 09:12:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q5LR7-0006KL-BF for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Jun 2023 09:12:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q5LQj-000327-DQ; Sat, 03 Jun 2023 03:12:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5LQh-00031q-Dh for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2023 03:12:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q5LQh-0007ag-55 for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2023 03:12:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q5LQg-0003xf-Ga for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2023 03:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Jun 2023 07:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63844 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.168577631915215 (code B ref -1); Sat, 03 Jun 2023 07:12:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 3 Jun 2023 07:11:59 +0000 Original-Received: from localhost ([127.0.0.1]:41441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5LQd-0003xJ-9c for submit@debbugs.gnu.org; Sat, 03 Jun 2023 03:11:59 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:52150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5LQb-0003xB-25 for submit@debbugs.gnu.org; Sat, 03 Jun 2023 03:11:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5LQX-00031T-Ku for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2023 03:11:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5LQX-0007a2-CT; Sat, 03 Jun 2023 03:11:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/i0C++A54Nfx9C2SAG5qJRiq153x7DZKgTspq6GAULg=; b=ikLMFwY2G+Bt 8MnaifBhxllCgqcYdlRqv3ZLUjVmAzrKdYKeeW2pmDty43ZnHAcJ+rH1aIllbPi2FFpJ+skrr0d00 3aRvP6I76YTYx27+BJ7VqUR1ZWj6eV1GXuSFyeZkePLzeALYY56D8DCqLJphKzl0vR0TNluFf+2Yb obTLZheI7FollZKOURVe71q5krxNI8/M+FdL2pnAK4eHvPIRspdmgirXc6BHfl3hiGRRaIS4i6bP6 RviBX1pK0NlaW44qRHrnSFyung75svUu8UgfC08g1h6Bc5CirR6Cwd+C5Ns+WsbsgoxK+FhqEa8u9 8JGiU1am47YReCsRxzeQXA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5LQV-000612-4H; Sat, 03 Jun 2023 03:11:53 -0400 In-Reply-To: (message from kobarity on Fri, 02 Jun 2023 23:22:34 +0900) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262802 Archived-At: > Date: Fri, 02 Jun 2023 23:22:34 +0900 > From: kobarity > Cc: Eli Zaretskii > > I'm sorry, but I would like to revert my following fix: > > "Enhance Python font-lock to support multilines" > commit 4915ca5dd4245a909c046e6691e8d4a1919890c8 > > I have found that there are performance issues when editing a large > file. The issue can be reproduced as follows: > > 1. emacs -Q > 2. Open large Python file (e.g. turtle.py in Python) > 3. Near the top of the buffer, enter open paren and some characters. > > The above commit extends the region to be font-locked using > `python-nav-end-of-statement'. However, if there are unbalanced > parens, it may move point to the end of the buffer. This causes > almost the entire buffer to be font-locked, which is not acceptable > for large files. > > Attached is a patch to revert the commit in emacs-29 branch. Thanks, installed on the emacs-29 branch.